Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'make spelling' target to doc/ #10607

Merged
merged 6 commits into from
Aug 25, 2024
Merged

Conversation

rouault
Copy link
Member

@rouault rouault commented Aug 15, 2024

  • Fix various typos found by 'make spelling'
  • Add a 'make spelling' target to doc/
  • CI: enable 'make spelling'

@dbaston This may interfere with PR #10434 , especially since PR #10434 removes doc_build.yml which is modified by this PR to run 'make spelling' . How in the new setup 'make spelling' should be run?

@dbaston
Copy link
Member

dbaston commented Aug 15, 2024

How in the new setup 'make spelling' should be run?

We could add it as a step to readthedocs.yaml but it seems like it takes a while to run, so maybe it's better kept running independently through GitHub Actions?

@rouault
Copy link
Member Author

rouault commented Aug 15, 2024

so maybe it's better kept running independently through GitHub Actions?

sounds good to me

@rouault rouault force-pushed the doc_spelling branch 3 times, most recently from 578985b to 5f71b64 Compare August 15, 2024 21:37
@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2024

Coverage Status

coverage: 69.351% (-0.002%) from 69.353%
when pulling 49011e5 on rouault:doc_spelling
into 1196ed3 on OSGeo:master.

@rouault rouault added the documentation Issues and contributions to the documentation content label Aug 16, 2024
@rouault rouault merged commit c05292d into OSGeo:master Aug 25, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues and contributions to the documentation content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants