Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gdal_contour] Fix regression when fixed level == raster max #10885

Merged

Conversation

elpaso
Copy link
Collaborator

@elpaso elpaso commented Sep 27, 2024

Fix #10854

@elpaso elpaso added bug regression Bug that did not exist in a prior release labels Sep 27, 2024
alg/contour.cpp Outdated Show resolved Hide resolved
@rouault
Copy link
Member

rouault commented Sep 27, 2024

There's also some testing of it through autotest/cpp/gdal_unit_test (autotest/cpp/test_marching_squares_*.cpp files) which must be updated

elpaso and others added 2 commits September 28, 2024 07:59
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
@elpaso
Copy link
Collaborator Author

elpaso commented Sep 28, 2024

There's also some testing of it through autotest/cpp/gdal_unit_test (autotest/cpp/test_marching_squares_*.cpp files) which must be updated

The test was actually ok: I reverted part of my first commit.

@rouault rouault merged commit d04e73d into OSGeo:master Sep 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/3.9 bug regression Bug that did not exist in a prior release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gdal_contour behavior change between 3.8.4 and 3.9.0
2 participants