Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecuteSQL(): error out if SetSpatialFilter() fails #9645

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Apr 5, 2024

fixes #9623

@rouault
Copy link
Member Author

rouault commented Apr 5, 2024

Ultimately we'd rather want SetSpatialFilter() to return an error code rather than relying on CPLGetLastErrorType() / CPLGetErrorCount()... but that involves revisiting all drivers

@coveralls
Copy link
Collaborator

coveralls commented Apr 5, 2024

Coverage Status

coverage: 68.948% (+0.003%) from 68.945%
when pulling 59c8cea on rouault:fix_9623
into 79a77cf on OSGeo:master.

autotest/ogr/ogr_sql_test.py Show resolved Hide resolved
ogr/ogrsf_frmts/generic/ogrlayer.cpp Outdated Show resolved Hide resolved
@rouault rouault merged commit 2591341 into OSGeo:master Apr 14, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ogr2ogr: catch invalid -spat arguments better
3 participants