netCDF: Add BAND_NAMES creation option #9657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
reviewed
Apr 11, 2024
rouault
reviewed
Apr 14, 2024
frmts/netcdf/netcdfdataset.cpp
Outdated
| @@ -9104,7 +9104,7 @@ netCDFDataset *netCDFDataset::CreateLL(const char *pszFilename, int nXSize, | |||
|
|
|||
| CPLReleaseMutex(hNCMutex); // Release mutex otherwise we'll deadlock with | |||
| // GDALDataset own mutex. | |||
| netCDFDataset *poDS = new netCDFDataset(); | |||
| auto poDS = std::make_unique<netCDFDataset>(); | |||
There was a problem hiding this comment.
I'm not totally sure this change is safe. See the comments around the explicit "delete poDS" about mutex deadlocks
There was a problem hiding this comment.
// Release mutex otherwise we'll deadlock with
// GDALDataset own mutex.
Is this referring to use of hNCMutex by netCDFDataset ? Or is it referring to the m_poPrivate->hMutex in GDALDataset ?
There was a problem hiding this comment.
I believe this was a deadlock between hNCMutex and
Line 324 in 732d82c
There was a problem hiding this comment.
I've removed this change.
dbaston
force-pushed
the
netcdf-band-names
branch
from
2c43578
to
dcfdfa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an option to control the names of netCDF variables created by GDAL.
What are related issues/pull requests?
#1427
https://gis.stackexchange.com/questions/230642/setting-band-names-when-writing-multiple-layer-rasters-using-gdal-with-python
https://gis.stackexchange.com/questions/265204/gdal-creation-option-to-set-variable-name-to-netcdf
Tasklist