Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.eodag: handle cases when sorting parameters are not available #1170

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

HamedElgizery
Copy link
Contributor

No description provided.

@veroandreo
Copy link
Contributor

It seems ok to me, but could you provide an example to test this?

ninsbl
ninsbl previously requested changes Aug 15, 2024
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on these particular changes. This would also be an opportunity to consider also my arlier comment on sorting: #1152 (comment).

src/imagery/i.eodag/i.eodag.py Outdated Show resolved Hide resolved
src/imagery/i.eodag/i.eodag.py Outdated Show resolved Hide resolved
src/imagery/i.eodag/i.eodag.py Outdated Show resolved Hide resolved
@HamedElgizery
Copy link
Contributor Author

HamedElgizery commented Aug 18, 2024

This would also be an opportunity to consider also my arlier comment on sorting: #1152 (comment).

Thanks @ninsbl, I also came across this new sorting feature that will be released with EODAG 3 CS-SI/eodag#943
I think we can use it instead of the current implementation, I will look more into how it can be used.

@HamedElgizery
Copy link
Contributor Author

@ninsbl I updated the implementation as in here: #1152 (comment)

For the ingestiondate, shall we rename it to sensingtime? Yet, I believe that in i.sentinel.download ingestiondate is used to refer to the time the scene was indexed in the database... [1]

[1]https://scihub.copernicus.eu/twiki/do/view/SciHubUserGuide/FullTextSearch#:~:text=beginposition%3A%0Aendposition%3A-,ingestiondate,-%3A

@veroandreo
Copy link
Contributor

@ninsbl are you satisfied with @HamedElgizery changes? Would you mind approving them so we can merge? We are blocked at time.

@veroandreo veroandreo dismissed ninsbl’s stale review August 20, 2024 15:38

Changes requested were addressed.

@veroandreo veroandreo merged commit 9e49342 into OSGeo:grass8 Aug 20, 2024
7 checks passed
@HamedElgizery HamedElgizery deleted the eodag_sort_fix branch August 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants