v.rast.move: Move points by values from raster map #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP code for move of vector features positions by X and Y values given in two raster maps. This can move linear features without breaking the visual connection as points falling into the same raster cell are shifted by the same value. Alternative name would be v.rast.move because the big deal is that it is using raster to do the moving. The one example included now shows the principle, moves in X direction both ways depending on the raster values. My use case is randomizing a set of lines (connected and not connected). Feedback welcome.
…rtant role and it now moves vertices (points) of lines, not points.
…nt null check is needed).
wenzeslaus
changed the title
|
I renamed the module from v.move.points to v.rast.move because it moves vector using raster values (operates on vectors but the big deal is that it is using raster to do the moving). Tests are included, use pytest, and run locally. Example in the documentation is included, image is generated by a notebook. Pylint mostly passes locally. |
petrasovaa
reviewed
Jul 18, 2023
petrasovaa
requested changes
Jul 18, 2023
Right, it works only for lines. Other types would be a reasonable extension. Points are easy to do without this tool. I added a check which ignore other types and explained the behavior in the documentation. I also added a test which tests for this behavior. |
petrasovaa
approved these changes
Jul 18, 2023
cwhite911
pushed a commit
to cwhite911/grass-addons
that referenced
this pull request
Sep 19, 2023
Move of vector features positions by X and Y values given in two raster maps. This can move linear features without breaking the visual connection as points falling into the same raster cell are shifted by the same value. The name is v.rast.move because it moves vector using raster values (operates on vectors but the big deal is that it is using raster to do the moving). Alternative name would be v.rast.displacement. Original name was v.move.points. The one example included now shows the principle, moves in X direction both ways depending on the raster values. My use case is randomizing a set of lines (connected and not connected). Unlike v.perturb which moves points randomly, this works on lines and keeps the values at a given cell. Unlike v.transform combined with raster values in attribute columns, this operates on individual points in the line, not on the whole line. Copies first category, assumes layer 1. Drops attributes. Handles null values and extent mismatch. Warns about the nulls by default. Warns when integers are used (different null check is needed but not implemented).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move of vector features positions by X and Y values given in two raster maps. This can move linear features without breaking the visual connection as points falling into the same raster cell are shifted by the same value.
The name is v.rast.move because it moves vector using raster values (operates on vectors but the big deal is that it is using raster to do the moving). Alternative name would be v.rast.displacement. Original name was v.move.points.
The one example included now shows the principle, moves in X direction both ways depending on the raster values. My use case is randomizing a set of lines (connected and not connected).
Unlike v.perturb which moves points randomly, this works on lines and keeps the values at a given cell. Unlike v.transform combined with raster values in attribute columns, this operates on individual points in the line, not on the whole line.
Copies first category, assumes layer 1. Drops attributes.
Handles null values and extent mismatch. Warns about the nulls by default. Warns when integers are used (different null check is needed but not implemented).