Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and lenting #31

Merged
merged 21 commits into from
Jun 12, 2024
Merged

Formatting and lenting #31

merged 21 commits into from
Jun 12, 2024

Conversation

MohamedNasser8
Copy link
Collaborator

@MohamedNasser8 MohamedNasser8 commented Jun 4, 2024

Formatted the code using black.

There are some problems with linting as the lines should be less than 80 in length but black can't format comments which are more than 80 in length so I think all comments should be modified manually to fit in the required length.

Copy link
Collaborator

@ltorres6 ltorres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mohamed,

This is a good start.
Leaving you some comments here for you to work on.

.pre-commit-config.yaml Show resolved Hide resolved
.flake8 Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Show resolved Hide resolved
@ltorres6 ltorres6 self-requested a review June 12, 2024 00:43
Copy link
Collaborator

@ltorres6 ltorres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltorres6 ltorres6 merged commit 684dd2e into main Jun 12, 2024
9 checks passed
ltorres6 added a commit that referenced this pull request Jun 12, 2024
Merge pull request #31 from OSIPI/formatting-and-lenting
@ltorres6 ltorres6 deleted the formatting-and-lenting branch August 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants