Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality for one pipeline #34

Merged
merged 24 commits into from
Jul 15, 2024
Merged

Functionality for one pipeline #34

merged 24 commits into from
Jul 15, 2024

Conversation

stadmill
Copy link
Collaborator

Added functionality for a simple pipeline S->C->tofts model->parameters.

@stadmill stadmill requested a review from ltorres6 June 18, 2024 23:39
@ltorres6
Copy link
Collaborator

@MohamedNasser8 This PR is good to go. Can you fix the pipeline and merge into main?

ltorres6
ltorres6 previously approved these changes Jul 15, 2024
@stadmill stadmill dismissed ltorres6’s stale review July 15, 2024 19:50

The merge-base changed after approval.

split some long lines to be more readble
MohamedNasser8
MohamedNasser8 previously approved these changes Jul 15, 2024
@stadmill stadmill dismissed MohamedNasser8’s stale review July 15, 2024 20:09

The merge-base changed after approval.

MohamedNasser8
MohamedNasser8 previously approved these changes Jul 15, 2024
@stadmill stadmill dismissed MohamedNasser8’s stale review July 15, 2024 20:14

The merge-base changed after approval.

ltorres6
ltorres6 previously approved these changes Jul 15, 2024
Copy link
Collaborator

@ltorres6 ltorres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MohamedNasser8
MohamedNasser8 previously approved these changes Jul 15, 2024
@stadmill stadmill dismissed stale reviews from MohamedNasser8 and ltorres6 July 15, 2024 20:19

The merge-base changed after approval.

@ltorres6 ltorres6 self-assigned this Jul 15, 2024
@ltorres6 ltorres6 self-requested a review July 15, 2024 20:23
ltorres6
ltorres6 previously approved these changes Jul 15, 2024
Copy link
Collaborator

@ltorres6 ltorres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MohamedNasser8
MohamedNasser8 previously approved these changes Jul 15, 2024
@stadmill stadmill dismissed stale reviews from MohamedNasser8 and ltorres6 July 15, 2024 20:24

The merge-base changed after approval.

@ltorres6 ltorres6 self-requested a review July 15, 2024 20:39
@ltorres6 ltorres6 merged commit d766d98 into main Jul 15, 2024
5 checks passed
@ltorres6 ltorres6 deleted the dev branch August 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants