Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move method and its dependants from Controller #35

Open
Valefant opened this issue Mar 2, 2019 · 1 comment
Open

Move method and its dependants from Controller #35

Valefant opened this issue Mar 2, 2019 · 1 comment
Assignees
@ameliadiedrich
Labels
good first issue Good for newcomers

Comments

@Valefant
Copy link
Member

Valefant commented Mar 2, 2019

HelpProviderController#acceptEmergency should be moved to EmergencyController.
The same goes for the associated service HelpProviderService#acceptEmergency.

The tests which we have written so far should then be adjusted too.
HelpProviderControllerTest#testAcceptEmergency to EmergencyControllerTest
DefaultHelpProviderServiceTest#testAcceptEmergency to DefaultEmergencyServiceTest
@Valefant Valefant added the good first issue Good for newcomers label Mar 2, 2019
@ameliadiedrich
Copy link
Member

I would like to take care of this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ameliadiedrich ameliadiedrich

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Valefant @ameliadiedrich