Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claudeでの解析 #26

Merged
merged 26 commits into from
Apr 30, 2024
Merged

Claudeでの解析 #26

merged 26 commits into from
Apr 30, 2024

Conversation

aiueo-1234
Copy link

Closes #25

miyaji255
miyaji255 requested changes Apr 29, 2024
View reviewed changes
KoeBook.Core/Services/ClaudeService.cs Outdated Show resolved Hide resolved
miyaji255
miyaji255 reviewed Apr 29, 2024
View reviewed changes
KoeBook.Core/Services/StyleBertVitsClientService.cs
Comment on lines +32 to +33
var baseUri = new Uri(root);
var requestUri = new Uri(baseUri, path);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uriを経由するようにした理由は何ですか？

Copy link
Author

@aiueo-1234 aiueo-1234 Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

単純にhttpclientが使われているのと、元の結合方法だとroot//pathになったのでどっちに/をいれるのかを考えたくないからです

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

外部に公開しているわけでもないので/あるなしの両方を許容する必要はないと思います。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uriを経由したほうが安全だと思うのでこのほうが良いと思います。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実行したらデバッグ時に自明にわかるバグなので別にそこまでする必要はないと思います。

Copy link
Author

@aiueo-1234 aiueo-1234 Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いま思い出しましたが、一度間違えてrootを入力後にアプリを終了させると、mockに切り替えない限りアプリが起動できなくなる（StyleBertVtisにアクセスできない->エラー->アプリ終了）のでダメです。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それはすみません。こちらの実装の問題ですので #40 で修正します

@aiueo-1234 aiueo-1234 requested a review from miyaji255 April 29, 2024 08:38
@aiueo-1234 aiueo-1234 marked this pull request as ready for review April 29, 2024 08:41
@aiueo-1234 aiueo-1234 requested a review from miyaji255 April 29, 2024 09:22
@aiueo-1234 aiueo-1234 requested a review from miyaji255 April 29, 2024 10:11
@aiueo-1234 aiueo-1234 requested a review from miyaji255 April 29, 2024 15:37
miyaji255
miyaji255 previously approved these changes Apr 30, 2024
View reviewed changes
@aiueo-1234 aiueo-1234 enabled auto-merge April 30, 2024 16:06
@aiueo-1234 aiueo-1234 merged commit 9ca7a6c into main Apr 30, 2024
2 checks passed
@aiueo-1234 aiueo-1234 deleted the herring/claudia branch April 30, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miyaji255 miyaji255 miyaji255 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Claudeでの解析
3 participants
@aiueo-1234 @miyaji255 @herring101