Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German Translation of 2025 GenAI Top 10 #528

Open
wants to merge 2 commits into
base: translations/de-DE
Choose a base branch
from

Conversation

phischde
Copy link
Contributor

@phischde phischde commented Jan 12, 2025

PR Checklist 🚨

Proposed changes

this PR will add a German translation of the 2025 GenAI Top 10.
A special thank you to @RicoKomenda for the excellent collaboration on this effort.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have x-referenced the appropriate issue this addresses within the projects board
  • I have applied the relevant labels this PR addresses - see below

Further comments

To ensure correct rendering, we verified the Markdown files using the OWASP PDF Tool 4.4.0 with the following command:

./owasp_pdf -y -l LLM_de-DE

Special thanks to @Setotet for his support.

Label Request

We kindly request that the translation label be added to this pull request. Unfortunately, we cannot apply it ourselves due to missing write access on the repository.

@Setotet
Copy link
Contributor

Setotet commented Jan 13, 2025

  1. Version on the cover page says "2.0" It should be "2025"
  2. Revision history should be updated adding the German revision after the original English revision.

@Setotet
Copy link
Contributor

Setotet commented Jan 13, 2025

Please squash the commits to one commit before merge.

Copy link
Contributor

@Setotet Setotet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three check points:

  1. paragraph spacing
  2. "#" or "Nr" after "Szenario"
  3. NB_SPACE usage after ###$
    Not all instances are commented; pls be comprehensive.

2_0_vulns/translations/de-DE/LLM01_PromptInjection.md Outdated Show resolved Hide resolved
2_0_vulns/translations/de-DE/LLM07_SystemPromptLeakage.md Outdated Show resolved Hide resolved
2_0_vulns/translations/de-DE/LLM04_DataModelPoisoning.md Outdated Show resolved Hide resolved
2_0_vulns/translations/de-DE/LLM07_SystemPromptLeakage.md Outdated Show resolved Hide resolved
2_0_vulns/translations/de-DE/LLM09_Misinformation.md Outdated Show resolved Hide resolved
2_0_vulns/translations/de-DE/LLM10_UnboundedConsumption.md Outdated Show resolved Hide resolved
2_0_vulns/translations/de-DE/LLM10_UnboundedConsumption.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Setotet Setotet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last two commennts:

  1. 2025-01-13 for German release date
  2. Unnecessary new line in LLM06.
    Otherwise, LGTM.

2_0_vulns/translations/de-DE/LLM06_ExcessiveAgency.md Outdated Show resolved Hide resolved
@Setotet
Copy link
Contributor

Setotet commented Jan 13, 2025

FYI -- How to remove appendices
Remove doc_appendix_titles in custom_data_LLM_de-DE.json:

"doc_appendix_titles": [
        ""
    ]

or
"doc_appendix_titles": []

@phischde
Copy link
Contributor Author

Thank you for your Feedback, @Setotet
All changes are pushed and commits are squashed.

@phischde phischde marked this pull request as ready for review January 14, 2025 19:26
@phischde phischde requested a review from talesh as a code owner January 14, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants