Code

Feat/add nasc fix#96

Code

Merged

beatfactor merged 77 commits intofeature/add-nasc-improvementsOceanStreamIO/echopype:feature/add-nasc-improvementsfrom feat/add-nasc-fixOceanStreamIO/echopype:feat/add-nasc-fixCopy head branch name to clipboardOct 24, 2023

+1,199-630

Commits

Commits on Aug 15, 2023

• chore(deps): add flox dependency >=0.7.2

  lsetiawan

  committed
  149d7da

• fix(commongrid): fixes 'compute_MVBS' so it can work better and scale

  Show description for d911c45
  lsetiawan

  committed
  d911c45

• docs: add small code comment

  lsetiawan

  committed
  a052854

• refactor: change how ping_time index is retrieved

  lsetiawan

  committed
  364ebce

• refactor: remove for loop for channel

  lsetiawan

  committed
  a0fb46a

Commits on Aug 24, 2023

• test(mvbs): add mock Sv datasets and tests for dims (#2)

  Show description for d5558e8
  leewujung

  authored
  d5558e8

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for a1e5ec1
  pre-commit-ci[bot]

  committed
  a1e5ec1

• fix: change dask to numpy

  Show description for f30df73
  lsetiawan

  authored
  f30df73

Commits on Aug 25, 2023

• refactor: Merge branch 'dev' into fix_mvbs

  Show description for c75d9a2
  lsetiawan

  committed
  c75d9a2

• feat: Add method argument

  Show description for 99f2b65
  lsetiawan

  committed
  99f2b65

Commits on Aug 29, 2023

• fix(commongrid): Fixed to include lat lon

  Show description for a536d22
  lsetiawan

  committed
  a536d22

• refactor: Set defaults to recommended

  Show description for 3cdfebf
  lsetiawan

  committed
  3cdfebf

• feat(commongrid): Add 'range_var' argument to 'compute_MVBS'

  Show description for afa418d
  lsetiawan

  committed
  afa418d

• fix: Add missing attributes for lat lon

  lsetiawan

  committed
  7a861b4

• refactor: Merge branch 'dev' into fix_mvbs

  Show description for 41ad126
  lsetiawan

  committed
  41ad126

• test: Update test to use random generator

  lsetiawan

  committed
  53cebd4

• fix: Add case for no 'water_level'

  Show description for 22f03d2
  lsetiawan

  committed
  22f03d2

Commits on Aug 30, 2023

• refactor: Merge branch 'dev' into fix_mvbs

  lsetiawan

  committed
  9e2a0aa

• test(nasc): Remove 'compute_NASC' import to avoid failure

  lsetiawan

  committed
  0a4dbf3

Commits on Aug 31, 2023

• fix: Removed assumption on echo range max

  Show description for 7c52b28
  lsetiawan

  committed
  7c52b28

• test: Extract api test and add markings

  Show description for 828ab6d
  lsetiawan

  committed
  828ab6d

• refactor: Merge branch 'dev' into fix_mvbs

  lsetiawan

  committed
  60b025c

• test: Add latlon test for 'compute_MVBS'

  Show description for db53a72
  lsetiawan

  committed
  db53a72

• test: Add small get_MVBS_along_channels test

  Show description for 3f24590
  lsetiawan

  committed
  3f24590

• refactor: Merge branch 'dev' into fix_mvbs

  lsetiawan

  committed
  5a963bd

Commits on Sep 1, 2023

• refactor: Integrate suggested changes

  Show description for f3c3503
  lsetiawan

  committed
  f3c3503

• test: Added check for position values

  lsetiawan

  committed
  7d457d5

• test: Update range_meter_bin to strings

  lsetiawan

  committed
  6a33efa

Commits on Sep 2, 2023

• test: Added 'compute_MVBS' values test

  lsetiawan

  committed
  b64eca3

• Update echopype/tests/utils/test_processinglevels_integration.py

  Show description for f00c291
  emiliom

  authored
  f00c291

Commits on Sep 8, 2023

• test: Add 'nan' sprinkles

  Show description for 456fb50
  lsetiawan

  committed
  456fb50

• revert: Revert the use of 'pint'

  Show description for 8578432
  lsetiawan

  committed
  8578432

• feat: Allow 'range_bin' to have space

  lsetiawan

  committed
  31032af

• fix: Apply suggestions from code review

  Show description for d8dd4f8
  

  lsetiawan

  and

  emiliom

  authored
  d8dd4f8

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 5e5e19e
  pre-commit-ci[bot]

  committed
  5e5e19e

• test: Fix test text for wrong unit

  lsetiawan

  committed
  343b31b

• test: Remove the 'e.g.' part on pytest

  Show description for ab89fba
  lsetiawan

  committed
  ab89fba

Commits on Sep 9, 2023

• refactor: Merge branch 'dev' into fix_mvbs

  lsetiawan

  committed
  09eb7b7

Commits on Sep 17, 2023

• revive the function to make changes easier to see

  leewujung

  committed
  527c076

• add TODOs

  leewujung

  committed
  b6ffa59

• add computation steps

  leewujung

  committed
  7626357

• Merge branch 'fix_mvbs' into fix-nasc

  leewujung

  committed
  344e997

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for adafff5
  pre-commit-ci[bot]

  committed
  adafff5

• remove unused _lin2log

  leewujung

  committed
  fe9028e

Commits on Sep 20, 2023

• test: Remove remnant for test_ek.py

  lsetiawan

  committed
  d510d25

• refactor: Extract range_bin parsing and add close arg

  Show description for 8aa9201
  lsetiawan

  committed
  8aa9201

• refactor: Update arg types to include interval index

  Show description for 73fb446
  lsetiawan

  committed
  73fb446

• test: Update tests to have brute force creation

  Show description for 744228d
  lsetiawan

  committed
  744228d

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 48573fe
  pre-commit-ci[bot]

  committed
  48573fe

• test: Fix brute force mvbs gen

  Show description for f1df1d6
  lsetiawan

  committed
  f1df1d6

• chore: Clean up old code for doing compute MVBS

  Show description for 93b17b6
  lsetiawan

  committed
  93b17b6

• chore(pytest): Added custom markers 'unit' and 'integration'

  lsetiawan

  committed
  9443c2a

• docs: Update docstring for compute_MVBS

  Show description for 6eec56b
  lsetiawan

  committed
  6eec56b

• refactor: Merge branch 'dev' into fix_mvbs

  lsetiawan

  committed
  3492b36

• refactor: Merge branch 'fix_mvbs' into fix_nasc

  lsetiawan

  committed
  330811a

Commits on Sep 21, 2023

• refactor: Change 'parse_range_bin' to 'parse_x_bin'

  Show description for 56795a5
  lsetiawan

  committed
  56795a5

• refactor: Merge branch 'fix_mvbs' into fix_nasc

  lsetiawan

  committed
  1ca632a

• refactor: Merge branch 'dev' into fix_nasc

  lsetiawan

  committed
  ca25b9b

Commits on Sep 22, 2023

• refactor: Initial unification of MVBS and NASC

  Show description for 935e74b
  lsetiawan

  committed
  935e74b

• refactor: Merge branch 'dev' of https://github.com/OSOceanAcoustics/echopype into fix_nasc

  lsetiawan

  committed
  49d335f

Commits on Sep 24, 2023

• fix typo when porting from notebook

  leewujung

  committed
  2647916

• correct attribute units from m to nmi

  leewujung

  committed
  578dccd

Commits on Sep 25, 2023

• refactor: Add typehints and use method

  lsetiawan

  committed
  6647a31

• feat: Add get_x_along_channels

  Show description for e0a9b1b
  lsetiawan

  committed
  e0a9b1b

• feat: Implement new 'compute_NASC'

  Show description for a28be13
  lsetiawan

  committed
  a28be13

• test: Renamed and moved get_x_along_channels test

  lsetiawan

  committed
  4c95251

• fix: Use 'ffill' and 'bfill'

  Show description for 7661fee
  lsetiawan

  committed
  7661fee

• feat: Allow import 'compute_NASC' from 'commongrid' module

  lsetiawan

  committed
  8e18072

• fix: Fix bug on setup and validate and test

  Show description for b50b0ca
  lsetiawan

  committed
  b50b0ca

Commits on Sep 26, 2023

• test: Update simple NASC integration test

  lsetiawan

  committed
  5b6e38c

• test: Add brute force values test for NASC

  lsetiawan

  committed
  78b5971

Commits on Oct 10, 2023

• chore: Apply suggestions from code review

  Show description for 21ed1cf
  

  lsetiawan

  and

  leewujung

  authored
  21ed1cf

Commits on Oct 13, 2023

• refactor: Extract position reduction

  lsetiawan

  committed
  631c64d

• refactor: Separate sv mean and raw computations

  lsetiawan

  committed
  7ee877b

• test: Remove empty test_nasc.py

  lsetiawan

  committed
  5063fbc

• docs: Update docs for functions

  lsetiawan

  committed
  501df87

• refactor: Move helper funcs to utils.py

  lsetiawan

  committed
  f7677af