Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned Plugin] Spool Manager #1213

Closed
wizardkitty opened this issue Jul 10, 2023 · 25 comments · Fixed by #1258
Closed

[Abandoned Plugin] Spool Manager #1213

wizardkitty opened this issue Jul 10, 2023 · 25 comments · Fixed by #1258

Comments

@wizardkitty
Copy link

Which Plugin?

https://plugins.octoprint.org/plugins/SpoolManager/

Link to ticket on plugin's issue tracker confirming abandonment

OllisGit/OctoPrint-SpoolManager#333

Is there someone open to adopting it?

No response

@wizardkitty
Copy link
Author

https://github.com/mdziekon/OctoPrint-SpoolManager is a working version so they may be willing to adopt it.

@jneilliii
Copy link
Contributor

@mdziekon any interest in adopting the plugin? @OllisGit are you done with plugin development?

@mdziekon
Copy link
Contributor

mdziekon commented Jul 11, 2023

@jneilliii yes, I'm willing to provide at least basic maintenance. My fork might still need some technical preparation for full "take over" (like fixing dev / pre-release workflows), but other than that it should be ready for registration into plugins repository.

I'm also willing to take over OllisGit's OctoPrint-PrintJobHistory (my fork: https://github.com/mdziekon/OctoPrint-PrintJobHistory) at some point, but:

  • I guess it requires a separate issue here
  • The fork is not prepared for that (needs metadata & README updates)

@jneilliii
Copy link
Contributor

jneilliii commented Jul 11, 2023

Great, whenever you're ready you can submit a PR here for the changes. There are a couple of adoption PRs you can take a look at for what needs to be modified as example, but in general it's update authors list, URLs, and the update overlays. Feel free to ask any questions related here or in discord in the dev-plugins channel.

@Hottabych-
Copy link

Hi,
I don't know the processes if s.o. is willing to take over the responsibility. So my question when and where can I see a status change? At the moment the label is 'abandoned' here, will that change or is the label tight with the name (&plugin) of the original supporter?
My personal thank to @mdziekon to take over the responsibility for these two plugins (& PrintJobHistory; correct?) from olli.

@mdziekon
Copy link
Contributor

@Hottabych- can't speak for sure about the process, but I assume that as soon as I create a Pull Request here and it gets accepted & merged, the plugins repository should notify people about the new version. I guess @jneilliii could verify whether that's the case.

And yes, I'm planning to provide at least basic maintenance PrintJobHistory as well. It's taking me a bit longer than anticipated to prepare for SpoolManager take-over, but once I get past personal stuff, and prepare 2.0 version, I'll create a PR here to make things official.

@jneilliii
Copy link
Contributor

Yes, once we go through the process, end users will just get notified of a new version available from your forked version based on the software update overlay. So prior to submitting that PR, make sure you've done a version bump on your repo that is higher than the original. You can find a complete example adoption PR here.

@OllisGit
Copy link
Contributor

Hi! I AM STILL HERE ;-)

I know it was really quiet around my plugins, but I did a "sabbatical". So, no plugin-development, main focus was working in my new job.

I am happy that someone will take over the responsiblilty for the plugins....but...I don't want to hand over responsibility just yet.

So, my suggestion is that I get in contact with @mdziekon, review the changes in his fork and will discuss the next steps, (maybe here in the ticket)

@jneilliii
Copy link
Contributor

Thanks for finally responding @OllisGit, first step would be to close these abandonment tickets here and in your repos...

@flaviut
Copy link

flaviut commented Nov 5, 2023

Hey @OllisGit, I appreciate your hard work on these plugins; they've been very useful!

But despite your intent, it doesn't seem like you've gotten a chance to work on them. Can you please allow them to be formally abandoned so someone else can pick them up? There are some talented developers looking to maintain them.

@dimo414
Copy link

dimo414 commented Nov 5, 2023

@jneilliii IMO these tickets should be reopened, there's been no activity on these repos in months and no sign of @OllisGit.

@panatale1
Copy link

Is this project still abandoned? I would gladly help adopt it

@Hottabych-
Copy link

Hottabych- commented Nov 29, 2023

There was the same issue (abandon) with Ollis PrintJobHistory, please have a look at the solution how s.o. manage to take over (my understanding of that procedure) the project. This might be a solution for this project too. Many people are waiting for revitalize of this wonderful project.

@Webguyatwork
Copy link

I also created a fork and added external database support, tested with 2 separate installations of Octoprint on 2 separate printers. I can't say it couldn't benefit from some additional code review from other devs, but it does seem to be working with an external MySQL database for now.

See https://github.com/Webguyatwork/OctoPrint-SpoolManager if you'd like to play around with it in an offline dev environment. If @OllisGit will accept a PR, I can send one. It seems other PRs have gone unanswered.

@broderickhyman
Copy link

@dojohnso I noticed that you are now the maintainer of PrintJobHistory, any interest in taking over this project as well? I am interested myself but don't think I have the time commitment at the moment to take on a full existing project. I hope to contribute some bug fixes to these projects though when possible.

@Hottabych-
Copy link

Hottabych- commented Dec 1, 2023

@Webguyatwork

, but it does seem to be working with an external MySQL database for now.
Sounds interesting for me. I will get in 2 weeks a second printer ;-) so like to test it soon after my current 24h print has finished.

@dojohnso
Copy link
Contributor

dojohnso commented Dec 1, 2023

@dojohnso I noticed that you are now the maintainer of PrintJobHistory, any interest in taking over this project as well? I am interested myself but don't think I have the time commitment at the moment to take on a full existing project. I hope to contribute some bug fixes to these projects though when possible.

if no one else wants to take it, i could. but like with PrintJobHistory, i'll only have time to focus on immediate bug fixes and minor enhancements, so if someone else wants to do more with it sooner, please feel free to step in. the process to take it is pretty straight forward, my PR is here as a reference if anyone is curious about what needs to be changed here. #1248

@Webguyatwork
Copy link

I really want to see my external database enhancements released to everyone, but I really don't want to take over ownership of the plugin due to my own time constraints. If we can decide here who can take it over officially, I would definitely like to help contribute.

@Hottabych-
Copy link

Sounds like a good fit for me, we have 4 persons who are willing to contribute: @dojohnso, @Webguyatwork, @broderickhyman and @panatale1 so no one is alone.
Now we need a person with the hat on ... @dojohnso? you have the experience with the last one from Olli
If anybody need I can help in testing; but progamming ... ;-) you don't need Assembler, Pascal and Fortran 77 any more.

@dojohnso
Copy link
Contributor

dojohnso commented Dec 3, 2023

ha sure, i'll volunteer as tribute :) i'll work on this tomorrow

@dojohnso
Copy link
Contributor

dojohnso commented Dec 6, 2023

submitted #1255

@jneilliii jneilliii reopened this Dec 7, 2023
@Hottabych-
Copy link

Hottabych- commented Dec 9, 2023

As I understand this this plugin is now under maintenance of @dojohnso - correct? Thanks a lot for this. So why is there still an 'abandoned' sign? Second question, @Webguyatwork could you merge your database enhancements into the dev tree of dojohnso? I think this would be a great feature for people who have more than one printer.

@dojohnso
Copy link
Contributor

dojohnso commented Dec 9, 2023

As I understand this this plugin is now under maintenance of @dojohnso - correct? Thanks a lot for this. So why is there still an 'abandoned' sign? Second question, @Webguyatwork could you merge your database enhancements into the dev tree of dojohnso? I think this would be a great feature for people who have more than one printer.

It's coming. They found a minor issue with my initial release that I had to fix. Just waiting for them to confirm and finalize.

@Webguyatwork
Copy link

As I understand this this plugin is now under maintenance of @dojohnso - correct? Thanks a lot for this. So why is there still an 'abandoned' sign? Second question, @Webguyatwork could you merge your database enhancements into the dev tree of dojohnso? I think this would be a great feature for people who have more than one printer.

I'm waiting on the official hand-off to complete, then yes, I'll attempt to merge my changes in.

@Webguyatwork
Copy link

Pull request for external DB support is pending approval - dojohnso/OctoPrint-SpoolManager#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.