Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned Plugin] SpoolManager #1319

Open
rtrout opened this issue Sep 4, 2024 · 9 comments
Open

[Abandoned Plugin] SpoolManager #1319

rtrout opened this issue Sep 4, 2024 · 9 comments

Comments

@rtrout
Copy link

rtrout commented Sep 4, 2024

Which Plugin?

https://github.com/dojohnso/OctoPrint-SpoolManager

Link to ticket on plugin's issue tracker confirming abandonment

https://community.octoprint.org/t/is-spool-manager-still-in-development/60025/6

dojohnso/OctoPrint-SpoolManager#54

Is there someone open to adopting it?

No response

@GitIssueBot
Copy link

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/is-spool-manager-still-in-development/60025/7

@jneilliii
Copy link
Contributor

would like to get @dojohnso 's input directly rather than taking information second hand.

@rtrout
Copy link
Author

rtrout commented Sep 5, 2024

would like to get @dojohnso 's input directly rather than taking information second hand.

Doug has now responded here:
dojohnso/OctoPrint-SpoolManager#54 (comment)

@WildRikku
Copy link
Contributor

WildRikku commented Sep 5, 2024

I saw mdziekon/Octoprint-SpoolManager which was another fork of Olli's repository. It has quite a few commits but no recent ones. I posted an issue there asking if the maintainer is still interested in the plugin. Otherwise, I might think about taking it over. I was originally interested in FilamentManager for an integration with another plugin but saw that it has been abandoned, too, and people were using SpoolManager now.

@dojohnso
Copy link
Contributor

dojohnso commented Sep 5, 2024

would like to get @dojohnso 's input directly rather than taking information second hand.

Yeah I don't have the time to work on it so you all can move ahead with whatever is needed to take this over. same for my PrintJobHistory plugin

@WildRikku
Copy link
Contributor

Alright, I can take over the SpoolManager plugin. I spent the last night figuring out some things and think I can handle the codebase and existing issues and also have some fun. :)

I created a fork, activated issues and made some notes already. https://github.com/WildRikku/OctoPrint-SpoolManager

I also forked this repository and started preparing the pull request that would seal the takeover if I understood it correctly. I use this PR as reference: https://github.com/OctoPrint/plugins.octoprint.org/pull/1255/files
I am unsure about the changes made to notices.yaml and update_check_overlays.yaml. The first I think is to re-distribute the plugin without making a release? I'd write a bugfix I want to work on anyway and make a release as an exercise, so no change necessary then?
And for update_check_overlays.yaml, that looks like it does the same? Or do they work together and one is for notification and one is for actually pointing to new source? Would I add my lines to the files or replace those from the previous PR?

@jneilliii
Copy link
Contributor

Or do they work together and one is for notification and one is for actually pointing to new source? Would I add my lines to the files or replace those from the previous PR?

This is exactly the situation, they each control different aspects of the notification and update process.

I also forked this repository and started preparing the pull request that would seal the takeover if I understood it correctly. I use this PR as reference: #1255 (files)

Yes, this is a good example. You would also want to remove the abandoned setting currently in the top of SpoolManager.md file.

@WildRikku
Copy link
Contributor

Thank you. I have opened #1324 accordingly (at least I hope so).

@rtrout
Copy link
Author

rtrout commented Sep 15, 2024

Big thank you @WildRikku, 1.7.4 fixed the CSV download bug for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

5 participants