Run powershell scripts with -NoProfile if ExecuteWithoutProfile is se…

…t and true

source/Calamari.Tests/Calamari.Tests.csproj

@@ -416,6 +416,9 @@
     <None Include="Fixtures\PowerShell\Scripts\Exit2.ps1">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Include="Fixtures\PowerShell\Scripts\Profile.ps1">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Include="Fixtures\PowerShell\Scripts\Parameters.ps1">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

source/Calamari.Tests/Fixtures/PowerShell/PowerShellFixture.cs

@@ -37,6 +37,56 @@ public void ShouldCustomizePowerShellVersionIfRequested(string customPowerShellV
             }
         }
 
+        [Test]
+        [Category(TestEnvironment.CompatibleOS.Windows)]
+        [TestCase("true", true)]
+        [TestCase("false", false)]
+        [TestCase("", false)]
+        [TestCase(null, false)]
+        public void ShouldCallWithNoProfileWhenVariableSet(string executeWithoutProfile, bool calledWithNoProfile)
+        {
+            var variablesFile = Path.GetTempFileName();
+
+            var variables = new VariableDictionary();
+            if(executeWithoutProfile != null)
+                variables.Set(SpecialVariables.Action.PowerShell.ExecuteWithoutProfile, executeWithoutProfile);
+            variables.Save(variablesFile);
+
+            using (new TemporaryFile(variablesFile))
+            {
+                var output = Invoke(Calamari()
+                    .Action("run-script")
+                    .Argument("script", GetFixtureResouce("Scripts", "Profile.ps1"))
+                    .Argument("variables", variablesFile));
+
+                output.AssertSuccess();
+                var allOutput = string.Join(Environment.NewLine, output.CapturedOutput.Infos);
+                Assert.That(allOutput.Contains("-NoProfile") == calledWithNoProfile);
+            }
+        }
+
+        [Test]
+        [Category(TestEnvironment.CompatibleOS.Windows)]
+        public void ShouldNotCallWithNoProfileWhenVariableNotSet()
+        {
+            var variablesFile = Path.GetTempFileName();
+
+            var variables = new VariableDictionary();
+            variables.Set(SpecialVariables.Action.PowerShell.ExecuteWithoutProfile, "true");
+            variables.Save(variablesFile);
+
+            using (new TemporaryFile(variablesFile))
+            {
+                var output = Invoke(Calamari()
+                    .Action("run-script")
+                    .Argument("script", GetFixtureResouce("Scripts", "Profile.ps1"))
+                    .Argument("variables", variablesFile));
+
+                output.AssertSuccess();
+                output.AssertOutput("-NoProfile");
+            }
+        }
+
         [Test]
         [Category(TestEnvironment.CompatibleOS.Windows)]
         public void ShouldCallHello()

source/Calamari.Tests/Fixtures/PowerShell/Scripts/Profile.ps1

@@ -0,0 +1,2 @@
+ # returns the commandline powershell was called with which lets us check for -NoProfile in our test
+ (gwmi win32_process | ? { $_.processname -eq "powershell.exe" }) | select commandline

source/Calamari/Deployment/SpecialVariables.cs

@@ -179,6 +179,7 @@ public class WindowsService
             public static class PowerShell
             {
                 public static readonly string CustomPowerShellVersion = "Octopus.Action.PowerShell.CustomPowerShellVersion";
+                public static readonly string ExecuteWithoutProfile = "Octopus.Action.PowerShell.ExecuteWithoutProfile ";
             }
         }
 

source/Calamari/Integration/Scripting/WindowsPowerShell/PowerShellBootstrapper.cs

@@ -58,6 +58,12 @@ public static string FormatCommandArguments(string bootstrapFile, CalamariVariab
             {
                 commandArguments.Append($"-Version {customPowerShellVersion} ");
             }
+            var executeWithoutProfile = variables[SpecialVariables.Action.PowerShell.ExecuteWithoutProfile];
+            bool noProfile;
+            if (bool.TryParse(executeWithoutProfile, out noProfile) && noProfile)
+            {
+                commandArguments.Append("-NoProfile ");
+            }
             commandArguments.Append("-NoLogo ");
             commandArguments.Append("-NonInteractive ");
             commandArguments.Append("-ExecutionPolicy Unrestricted ");