Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies the telemetry request doc page #2011

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

michaelnoonan
Copy link
Contributor

Previously, this page was brittle because it tried to describe every data element, making it harder to change telemetry, resulting in this page becoming out of date.

The detailed list isn't really needed any more because:

  1. Customers can download a preview of the request to see what is being sent.
  2. We have our GDPR page which describes our stance on data privacy and our compliance.

Previously, this page was brittle because it tried to describe every data element, making it harder to change telemetry, resulting in this page becoming out of date.

The detailed list isn't really needed any more because:

1. Customers can download a preview of the request to see what is being sent.
2. We have our GDPR page which describes our stance on data privacy and our compliance.
@steve-fenton-octopus
Copy link
Contributor

I updated the meta description to improve it and to trigger the new test action that runs on pull requests.

@steve-fenton-octopus
Copy link
Contributor

Hey @jraddon-octopus - I just wanted to check in on this PR. If you need help with the review, let me know.

Removed detail on the frequency given that is a variable that could change and can be seen on customers end
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jraddon-octopus jraddon-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added an extra commit to remove the frequency, as some of the older versions that still exist currently send 3 times a day.

@michaelnoonan michaelnoonan merged commit 9963845 into main Oct 12, 2023
2 checks passed
@michaelnoonan michaelnoonan deleted the miken/telemetry-more-generic branch October 12, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants