Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows zero-file checks to pass. #2056

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Allows zero-file checks to pass. #2056

merged 1 commit into from
Oct 25, 2023

Conversation

steve-fenton-octopus
Copy link
Contributor

@steve-fenton-octopus steve-fenton-octopus commented Oct 25, 2023 •
edited
Loading

If all the changes found in the branch are excluded from checking, it raises an error.

This change supresses errors caused by zero files in the list to check.

Before

image

After

image

tonykelly-octopus
tonykelly-octopus approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tonykelly-octopus tonykelly-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steve-fenton-octopus steve-fenton-octopus merged commit ccde250 into main Oct 25, 2023
3 checks passed
@steve-fenton-octopus steve-fenton-octopus deleted the sf/allow-zero-file-checks-to-pass branch October 25, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonykelly-octopus tonykelly-octopus tonykelly-octopus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steve-fenton-octopus @tonykelly-octopus