Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo updated #2568

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Logo updated #2568

wants to merge 2 commits into from

Conversation

KMajkrzakOctopus
Copy link
Contributor

After:
Screenshot 2024-11-20 at 18 45 29
Screenshot 2024-11-20 at 18 45 34

@KMajkrzakOctopus
Copy link
Contributor Author

@steve-fenton-octopus could you take a look what is wrong in the deploy to channel pipeline? I don't want to mess up anything but seems like something is wrong in here:
tests/bookmark.spec.ts

@KMajkrzakOctopus
Copy link
Contributor Author

@steve-fenton-octopus could you take a look what is wrong in the deploy to channel pipeline? I don't want to mess up anything but seems like something is wrong in here: tests/bookmark.spec.ts

Nevermind turns out someone fixed that with a latest pr

@steve-fenton-octopus
Copy link
Contributor

@KMajkrzakOctopus as the SVG is growing, I wonder if it might be an idea to move it into an .svg file so browsers can cache it, rather than inlining it? What are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KMajkrzakOctopus @steve-fenton-octopus