feat!: Rename DeploymentAction to DeploymentActionSlug for external f…

…eed trigger packages (#245) * feat!: rename DeploymentAction to DeploymentActionSlug for feed trigger packages * feat: add trigger types for external feed triggers to spec
OctopusDeploy · May 1, 2024 · e16546f · e16546f
1 parent 55cc5a1
commit e16546f
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/api/octopus_deploy.json b/api/octopus_deploy.json
@@ -38987,7 +38987,8 @@
             "AutoDeploy",
             "DeployLatestRelease",
             "DeployNewRelease",
-            "RunRunbook"
+            "RunRunbook",
+            "CreateRelease"
           ],
           "type": "string",
           "readOnly": true
@@ -39021,7 +39022,8 @@
             "DaysPerMonthSchedule",
             "DaysPerWeekSchedule",
             "MachineFilter",
-            "OnceDailySchedule"
+            "OnceDailySchedule",
+            "FeedFilter"
           ],
           "type": "string",
           "readOnly": true

diff --git a/api/spec.json b/api/spec.json
@@ -9804,7 +9804,8 @@
         "AutoDeploy",
         "DeployLatestRelease",
         "DeployNewRelease",
-        "RunRunbook"
+        "RunRunbook",
+        "CreateRelease"
       ],
       "type": "string"
     },
@@ -9840,7 +9841,8 @@
         "DaysPerMonthSchedule",
         "CronExpressionSchedule",
         "OnceDailySchedule",
-        "ContinuousDailySchedule"
+        "ContinuousDailySchedule",
+        "FeedFilter"
       ],
       "type": "string"
     },

diff --git a/pkg/filters/feed_trigger_filter.go b/pkg/filters/feed_trigger_filter.go
@@ -3,12 +3,12 @@ package filters
 import "github.com/OctopusDeploy/go-octopusdeploy/v2/pkg/packages"
 
 type FeedTriggerFilter struct {
-	Packages []packages.DeploymentActionPackage `json:"Packages,omitempty"`
+	Packages []packages.DeploymentActionSlugPackage `json:"Packages,omitempty"`
 
 	triggerFilter
 }
 
-func NewFeedTriggerFilter(packages []packages.DeploymentActionPackage) *FeedTriggerFilter {
+func NewFeedTriggerFilter(packages []packages.DeploymentActionSlugPackage) *FeedTriggerFilter {
 	return &FeedTriggerFilter{
 		Packages:      packages,
 		triggerFilter: *newTriggerFilter(FeedFilter),

diff --git a/pkg/packages/deployment_action_slug_package.go b/pkg/packages/deployment_action_slug_package.go
@@ -0,0 +1,6 @@
+package packages
+
+type DeploymentActionSlugPackage struct {
+	DeploymentActionSlug string `json:"DeploymentActionSlug,omitempty"`
+	PackageReference     string `json:"PackageReference,omitempty"`
+}