Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new functions for getting a packages not using a service #260

Merged
merged 2 commits into from
Jul 12, 2024
Merged

feat: add new functions for getting a packages not using a service #260

merged 2 commits into from
Jul 12, 2024

Conversation

hnrkndrssn
Copy link
Contributor

@hnrkndrssn hnrkndrssn commented Jul 12, 2024 •
edited
Loading

Refactors the following methods to no longer use a PackageService

  • GetById
  • GetAll

And adds the following methods:

  • Get
  • DeleteById

[sc-83932]

@hnrkndrssn hnrkndrssn self-assigned this Jul 12, 2024
@hnrkndrssn hnrkndrssn mentioned this pull request Jul 12, 2024
Merged
@hnrkndrssn @benPearce1
Update pkg/packages/package_service.go
66ec85f 
Co-authored-by: Ben Pearce <ben.pearce@octopus.com>
benPearce1
benPearce1 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@benPearce1 benPearce1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 one typo in the deprecated callout

@hnrkndrssn hnrkndrssn merged commit 950eb2f into main Jul 12, 2024
6 checks passed
@hnrkndrssn hnrkndrssn deleted the henrik/packageservice branch July 12, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benPearce1 benPearce1 benPearce1 approved these changes

@IsaacCalligeros95 IsaacCalligeros95 Awaiting requested review from IsaacCalligeros95

@HuyPhanNguyen HuyPhanNguyen Awaiting requested review from HuyPhanNguyen

Assignees

@hnrkndrssn hnrkndrssn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnrkndrssn @benPearce1