Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure OIDC account support #577

Merged
merged 3 commits into from
Dec 5, 2023
Merged

azure OIDC account support #577

merged 3 commits into from
Dec 5, 2023

Conversation

benPearce1
Copy link
Collaborator

@benPearce1 benPearce1 commented Nov 26, 2023

terraform file

resource "octopusdeploy_azure_openid_connect" "oidc" {
  application_id  = "82587d26-ee04-4446-aede-9e89b1ff2b4d"
  name            = "Azure OpenID Connect Account (OK to Delete)"
  subscription_id = "00000000-0000-0000-0000-000000000000"
  tenant_id       = "00000000-0000-0000-0000-000000000000"
  execution_subject_keys = ["space", "project"]
  health_subject_keys = ["space", "target", "type"]
  account_test_subject_keys = ["space", "type"]
}

resource "octopusdeploy_azure_service_principal" "azure_service_principal_account" {
  application_id  = "00000000-0000-0000-0000-000000000000"
  name            = "Azure Service Principal Account (OK to Delete)"
  password        = "###########" # required; get from secure environment/store
  subscription_id = "00000000-0000-0000-0000-000000000000"
  tenant_id       = "00000000-0000-0000-0000-000000000000"
}

terraform plan:

❯ terraform plan

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # octopusdeploy_azure_openid_connect.oidc will be created
  + resource "octopusdeploy_azure_openid_connect" "oidc" {
      + account_test_subject_keys         = [
          + "space",
          + "type",
        ]
      + application_id                    = "82587d26-ee04-4446-aede-9e89b1ff2b4d"
      + azure_environment                 = (known after apply)
      + environments                      = (known after apply)
      + execution_subject_keys            = [
          + "space",
          + "project",
        ]
      + health_subject_keys               = [
          + "space",
          + "target",
          + "type",
        ]
      + id                                = (known after apply)
      + name                              = "Azure OpenID Connect Account (OK to Delete)"
      + space_id                          = (known after apply)
      + subscription_id                   = "00000000-0000-0000-0000-000000000000"
      + tenant_id                         = "00000000-0000-0000-0000-000000000000"
      + tenant_tags                       = (known after apply)
      + tenanted_deployment_participation = (known after apply)
      + tenants                           = (known after apply)
    }

  # octopusdeploy_azure_service_principal.azure_service_principal_account will be created
  + resource "octopusdeploy_azure_service_principal" "azure_service_principal_account" {
      + application_id                    = "00000000-0000-0000-0000-000000000000"
      + azure_environment                 = (known after apply)
      + environments                      = (known after apply)
      + id                                = (known after apply)
      + name                              = "Azure Service Principal Account (OK to Delete)"
      + password                          = (sensitive value)
      + space_id                          = (known after apply)
      + subscription_id                   = "00000000-0000-0000-0000-000000000000"
      + tenant_id                         = "00000000-0000-0000-0000-000000000000"
      + tenant_tags                       = (known after apply)
      + tenanted_deployment_participation = (known after apply)
      + tenants                           = (known after apply)
    }

Plan: 2 to add, 0 to change, 0 to destroy.

terraform apply

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

octopusdeploy_azure_service_principal.azure_service_principal_account: Creating...
octopusdeploy_azure_openid_connect.oidc: Creating...
octopusdeploy_azure_service_principal.azure_service_principal_account: Creation complete after 0s [id=Accounts-269]
octopusdeploy_azure_openid_connect.oidc: Creation complete after 0s [id=Accounts-268]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

outcome:
image

@benPearce1 benPearce1 changed the title Bp/azure OIDC account azure OIDC account support Nov 27, 2023
@benPearce1 benPearce1 marked this pull request as ready for review November 27, 2023 03:31
Copy link
Contributor

@domenicsim1 domenicsim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Stuff 👍

results.xml

.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how we lived this long without it.

@benPearce1 benPearce1 merged commit ebc8a7f into main Dec 5, 2023
6 checks passed
@benPearce1 benPearce1 deleted the bp/azure-oidc-account branch December 5, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants