-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support process scoped variables #593
Conversation
…e detail to documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. If we can add (or update an existing) test to include the usage of this parameter would be nice.
terraform/49-variables/variables.tf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tenant scoped variables are already been tested here so it didn't seem necessary to test them again
integration_test.go
Outdated
if len(variableSet.Variables) != 7 { | ||
t.Fatalf("Expected 7 variables to be created") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figure we can just assert that the correct amount of variables are created, anything else would be covered by the fact the variable resources are created correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from maybe a quick tweak to the test to validate that the scope exists as expected, even just explicitly checking some known value for each differently scoped variable then feel free to merge.
🙇 Thanks for pushing this one forward
[SC-66829]
Based on #562
Result
go-octopusdeploy
version to include the changes that allow for process scope variable matching (see chore: Support process scoped variable scope matching OctopusDeploy/go-octopusdeploy#230)process
to variable scope schema to allow it to be used in terraform.Example
fixes #361