Add the worker_pool_id field to apply_terraform_template_action steps #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be worth updating the data-sources docs to remove "name" as part of the worker_pools query |
rain-on
approved these changes
Feb 13, 2024
| @@ -524,6 +524,14 @@ func flattenApplyTerraformTemplateAction(action *deployments.DeploymentAction) m | |||
| } | |||
| } | |||
|
|
|||
| if len(action.WorkerPool) > 0 { | |||
There was a problem hiding this comment.
Is there value in this function calling "flattenDeploymentAction", rather than flattenAction on line 497 - or is this a more correct fix?
| take = 1 | ||
| } | ||
|
|
||
| data "octopusdeploy_feeds" "feed_octopus_server__built_in_" { |
There was a problem hiding this comment.
should feed_octopus_server__built_in_ have double underscore, (between server and built) and ending "_"?
There was a problem hiding this comment.
👍 I can clean that up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
apply_terraform_template_actionstep does not have aworker_pool_idattribute, and setting the attribute in thepropertiesdoes not work.This PR adds the
worker_pool_idattribute to bringapply_terraform_template_actioninline with other steps like run_kubectl_script_action.Fixes #601