Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema and doc GitCredential, Lifecycles and TenantProjectVariable #717

Merged
merged 12 commits into from
Aug 8, 2024

Conversation

HuyPhanNguyen
Copy link
Collaborator

No description provided.

@HuyPhanNguyen HuyPhanNguyen changed the title WIP - Update schema and doc Update schema and doc GitCredential, Lifecycles and TenantProjectVariable Aug 6, 2024
Copy link
Collaborator

@IsaacCalligeros95 IsaacCalligeros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the Lifecycles default quantity to keep value. I'm not sure where the values coming from but it would be good if we can change that back to 0.

Copy link
Collaborator

@IsaacCalligeros95 IsaacCalligeros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuyPhanNguyen HuyPhanNguyen merged commit 7fade05 into main Aug 8, 2024
21 checks passed
@HuyPhanNguyen HuyPhanNguyen deleted the huy/update-schema-and-document branch August 8, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants