Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure resources deleted from Octopus are removed from state #720

Merged
merged 8 commits into from
Aug 8, 2024

Conversation

hnrkndrssn
Copy link
Contributor

@hnrkndrssn hnrkndrssn commented Aug 8, 2024

The old SDKv2 resources would remove a resource from state if Octopus returned a 404, this was removed in the migration so this PR adds this functionality back.

@hnrkndrssn hnrkndrssn self-assigned this Aug 8, 2024
@hnrkndrssn hnrkndrssn force-pushed the henrik/processapierrorv2 branch from a4e43d1 to f65c5b9 Compare August 8, 2024 04:20
@hnrkndrssn hnrkndrssn marked this pull request as ready for review August 8, 2024 05:04
Copy link
Collaborator

@IsaacCalligeros95 IsaacCalligeros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnrkndrssn hnrkndrssn merged commit b1a1cd2 into main Aug 8, 2024
21 checks passed
@hnrkndrssn hnrkndrssn deleted the henrik/processapierrorv2 branch August 8, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants