fix: fix datasource result blocks #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacCalligeros95
requested changes
Aug 22, 2024
@IsaacCalligeros95 I think when it comes to the datasource result set attributes, it probably doesn't matter. I think the resource schema types matter more |
docs/data-sources/variables.md
Outdated
| @@ -37,24 +36,11 @@ data "octopusdeploy_variables" "example" { | |||
| - `is_editable` (Boolean) Indicates whether or not this variable is considered editable. | |||
| - `is_sensitive` (Boolean) Indicates whether or not this resource is considered sensitive and should be kept secret. | |||
| - `prompt` (Attributes List) (see [below for nested schema](#nestedatt--prompt)) | |||
| - `scope` (Attributes List) As variable names can appear more than once under different scopes, a VariableScope must also be provided (see [below for nested schema](#nestedatt--scope)) | |||
There was a problem hiding this comment.
Looking at the old schema docs it looks like the scope should be Required, sorry I think I mislead you on the last review.
There was a problem hiding this comment.
the scope is a nested property of the variable, within a datasource the results are all readonly, I think this feels right
|
|
||
| - `description` (String) |
There was a problem hiding this comment.
I think these should still be Read only.
IsaacCalligeros95
requested changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #762