resource id should be readonly. space name on datasource should be optional

[benPearce1]

setup:

resource "octopusdeploy_lifecycle" "lifecycle" {
  id = "Lifecycles-1"
  space_id = data.octopusdeploy_space.space.id
  name = "lifecycle 2"
}

on 0.22.1

# octopusdeploy_lifecycle.lifecycle will be created
  + resource "octopusdeploy_lifecycle" "lifecycle" {
      + description = "description2"
      + id          = (known after apply)
      + name        = "lifecycle 2"
      + space_id    = "Spaces-1"
...

Lifecycle resource was created with id of Lifecycles-1762. From state:

"id": "Lifecycles-1762",
"name": "lifecycle 2",

Plan with 0.30.0-beta8

# octopusdeploy_lifecycle.lifecycle will be updated in-place
  ~ resource "octopusdeploy_lifecycle" "lifecycle" {
      ~ id          = "Lifecycles-1762" -> "Lifecycles-1"
        name        = "lifecycle 2"
        # (2 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan now fails validation as Id is readonly:

│ Error: Invalid Configuration for Read-Only Attribute
│ 
│   with octopusdeploy_lifecycle.lifecycle,
│   on main.tf line 32, in resource "octopusdeploy_lifecycle" "lifecycle":
│   32:   id = "Lifecycles-1"
│ 
│ Cannot set value for this attribute as the provider has marked it as read-only. Remove the configuration line setting the value.
│ 
│ Refer to the provider documentation or contact the provider developers for additional information about configurable and read-only attributes that are
│ supported.
╵

[benPearce1]

This means that the user cannot set the Id and will get an error

[benPearce1]

Looks like this was broken from #759

[benPearce1]

Use the helper function for consistency

[domenicsim1]

Good catch 🪝