Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty datasource results should be empty arrays #778

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

benPearce1
Copy link
Collaborator

@benPearce1 benPearce1 commented Sep 10, 2024

[sc-92171]

Fixes: #779

environments before:

  + env_output = {
      + environments = null
      + id           = "Environments 2024-09-10 01:49:17.322748 +0000 UTC"
      + ids          = null
      + name         = null
      + partial_name = "broken"
      + skip         = null
      + space_id     = null
      + take         = null
    }

environments after:

  + output     = {
      + environments = []
      + id           = "Environments 2024-09-10 02:43:19.719235 +0000 UTC"
      + ids          = null
      + name         = null
      + partial_name = "broken"
      + skip         = null
      + space_id     = "Spaces-982"
      + take         = null
    }

tag sets before:

  + output     = {
      + id           = "TagSets-2024-09-10 02:33:49.32293 +0000 UTC"
      + ids          = null
      + partial_name = "broken"
      + skip         = null
      + space_id     = null
      + tag_sets     = null
      + take         = null
    }

tag sets after:

  + output     = {
      + id           = "TagSets-2024-09-10 02:37:56.355514 +0000 UTC"
      + ids          = null
      + partial_name = "broken"
      + skip         = null
      + space_id     = null
      + tag_sets     = []
      + take         = null
    }

@benPearce1 benPearce1 merged commit 359e287 into main Sep 10, 2024
22 checks passed
@benPearce1 benPearce1 deleted the bp/empty-datasource-results branch September 10, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result sets for some datasources can be null
2 participants