Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty datasource results should be empty arrays #778

Merged
merged 3 commits into from
Sep 10, 2024

empty result set is empty array

e67e6aa
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: empty datasource results should be empty arrays #778

empty result set is empty array
e67e6aa
Select commit
Loading
Failed to load commit list.
GitHub Actions / Go Tests succeeded Sep 10, 2024 in 0s

190 passed, 0 failed and 12 skipped

Tests passed successfully

✅ junit-test-summary.xml

202 tests were completed in 394s with 190 passed, 0 failed and 12 skipped.

Test suite Passed Failed Skipped Time
github.com/OctopusDeploy/terraform-provider-octopusdeploy 0ms
github.com/OctopusDeploy/terraform-provider-octopusdeploy/internal 0ms
github.com/OctopusDeploy/terraform-provider-octopusdeploy/internal/environments 0ms
github.com/OctopusDeploy/terraform-provider-octopusdeploy/internal/errors 0ms
github.com/OctopusDeploy/terraform-provider-octopusdeploy/internal/projects 0ms
github.com/OctopusDeploy/terraform-provider-octopusdeploy/internal/test 0ms
github.com/OctopusDeploy/terraform-provider-octopusdeploy/octopusdeploy 95✅ 10⚪ 394s
github.com/OctopusDeploy/terraform-provider-octopusdeploy/octopusdeploy_framework 80✅ 2⚪ 146s
github.com/OctopusDeploy/terraform-provider-octopusdeploy/octopusdeploy_framework/schemas 15✅ 6ms
github.com/OctopusDeploy/terraform-provider-octopusdeploy/octopusdeploy_framework/util 0ms

✅ github.com/OctopusDeploy/terraform-provider-octopusdeploy/octopusdeploy

✅ TestKubernetesAgentWorkerResource
✅ TestAccAWSAccountBasic
✅ TestK8sPodAuthTargetResource
✅ TestListeningTargetResource
✅ TestAccUserRoleBasic
✅ TestTerraformApplyStepWithWorkerPool
✅ TestAccUserBasic
✅ TestAccDataSourceChannels
✅ TestSpaceResource
✅ TestAccSpaceImportBasic
✅ TestTokenAccountBasic
✅ TestUsersAndTeams
✅ TestAccOctopusDeployAzureSubscriptionAccountBasic
✅ TestAzureSubscriptionAccountResource
✅ TestAccOctopusDeployDeploymentProcessBasic
✅ TestAccKubernetesClusterDeploymentTargetAws
✅ TestPollingTargetResource
✅ TestAccCloudRegionDeploymentTargetImportBasic
✅ TestSshAccountResource
✅ TestAccOctopusDeployRunKubectlScriptAction
✅ TestAccDataSourceUsers
✅ TestAwsAccountExport
✅ TestAzureAccountResource
✅ TestCertificateResource
✅ TestAccOctopusDeployChannelBasicWithUpdate
✅ TestAccCloudRegionDeploymentTargetBasic
✅ TestGcpAccountResource
✅ TestProjectTriggerResource
✅ TestWorkerPoolResource
✅ TestAccTeamBasic
✅ TestAccOctopusDeployWindowsServiceFeature
✅ TestAccDataSourceWorkerPools
✅ TestAccOctopusDeployDeploymentProcessWithImpliedPrimaryPackage
✅ TestPackageFeedCreateReleaseTriggerResources
⚪ TestAccAWSOIDCAccountBasic
⚪ TestAccOctopusDeployAzureOpenIDConnectAccountBasic
⚪ TestAccOctopusDeployChannelWithOneRule
⚪ TestAccOctopusDeployChannelWithOneRuleWithUpdate
⚪ TestAccOctopusDeployChannelWithTwoRules
⚪ TestAccOctopusDeployDeploymentProcessWithActionTemplate
⚪ TestAccOctopusDeployDynamicWorkerPoolBasic
⚪ TestAccListeningTentacleDeploymentTarget
⚪ TestAccScopedUserRole
⚪ TestAccTeamUserRole
✅ TestAccDataSourceSpaces
✅ TestProvider
✅ TestProvider_impl
✅ TestAzureCloudServiceTargetResource
✅ TestAccOctopusDeployAzureWebAppDeploymentTargetBasic
✅ TestDeploymentProcessWithGitDependency
✅ TestAccGcpAccountBasic
✅ TestAccOctopusDeployStaticWorkerPoolBasic
✅ TestAccOctopusDeployApplyTerraformAction
✅ TestExpandRunScriptAction
✅ TestExpandDeploymentActionContainer
✅ TestExpandDeploymentActionPackage
✅ TestFlattenDeploymentActionPackage
✅ TestExpandDeploymentActionSlugPackages_NilExpandsToNil
✅ TestExpandDeploymentActionSlugPackages_EmptyExpandsToEmpty
✅ TestExpandDeploymentActionSlugPackages_ArrayExpandsCorrectly
✅ TestExpandDeploymentActionSlugPrimaryPackages_NilExpandsToNil
✅ TestExpandDeploymentActionSlugPrimaryPackages_EmptyExpandsToEmpty
✅ TestExpandDeploymentActionSlugPrimaryPackages_ArrayExpandsCorrectly
✅ TestFlattenDeploymentActionSlugPackages_NilFlattensToNil
✅ TestFlattenDeploymentActionSlugPackages_EmptyFlattensToNil
✅ TestFlattenDeploymentActionSlugPackages_IgnoresPrimaryPackages_NoPackagesAfterFlattening
✅ TestFlattenDeploymentActionSlugPackages_IgnoresPrimaryPackages_ArrayFlattensCorrectly
✅ TestFlattenDeploymentActionSlugPrimaryPackages_NilFlattensToNil
✅ TestFlattenDeploymentActionSlugPrimaryPackages_EmptyFlattensToNil
✅ TestFlattenDeploymentActionSlugPrimaryPackages_IgnoresPackages_NoPrimaryPackagesAfterFlattening
✅ TestFlattenDeploymentActionSlugPrimaryPackages_IgnoresPackages_ArrayFlattensCorrectly
✅ TestExpandDeploymentAction
✅ TestFlattenDeploymentAction
✅ TestGetSliceFromTerraformTypeList
✅ TestAccDataSourceProjects
✅ TestAzureServiceFabricTargetResource
✅ TestSSHKeyBasic
✅ TestAccUserImportBasic
✅ TestAccOctopusDeployAzureServicePrincipalAccountBasic
✅ TestProjectChannelResource
✅ TestAccKubernetesClusterDeploymentTargetBasic
✅ TestAccKubernetesClusterDeploymentTargetGcp
✅ TestK8sTargetResource
✅ TestK8sTargetWithCertResource
✅ TestAccDataSourceSpaces
✅ TestAccProjectGroup
✅ TestProjectScheduledTriggerResources
✅ TestSshTargetResource
✅ TestTokenAccountResource
✅ TestAccUserRolePermissions
✅ TestAccOctopusDeployDeployWindowsServiceAction
✅ TestAccRunScriptAction
✅ TestAccDataSourceAccounts
✅ TestAccOctopusDeployChannelBasic
✅ TestCloudRegionTargetResource
✅ TestKubernetesDeploymentTargetResource
✅ TestPollingSubscriptionIdResource
✅ TestAccSpaceBasic
✅ TestAzureWebAppTargetResource
✅ TestAccOctopusDeployCertificateBasic
✅ TestKubernetesDeploymentTargetData
✅ TestMachinePolicyResource
✅ TestOfflineDropTargetResource
✅ TestAccOctopusDeployDeployKubernetesSecretAction
✅ TestAccOctopusDeployManualInterventionAction

✅ github.com/OctopusDeploy/terraform-provider-octopusdeploy/octopusdeploy_framework

✅ TestAccDataSourceFeeds
✅ TestAccOctopusDeployEnvironmentBasic
✅ TestAccOctopusDeployLibraryVariableSetWithUpdate
✅ TestAccOctopusDeployScriptModuleBasic
✅ TestVariableResource
✅ TestAccOctopusDeployArtifactoryGenericFeed
✅ TestGitCredentialsResource
✅ TestGithubFeedResource
✅ TestAccLifecycleWithUpdate
✅ TestScriptModuleResource
✅ TestTagSetAndTag
✅ TestTagSetResource
✅ TestTenantProjectResource_UpgradeFromSDK_ToPluginFramework
✅ TestEcrFeedResource
✅ TestProjectGroupResource
✅ TestProjectWithGitUsernameExport
✅ TestAccTenantCommonVariableBasic
✅ TestTenantsResource
✅ TestAccDataSourceScriptModules
✅ TestAccDataSourceProjectGroups
✅ TestNugetFeed_UpgradeFromSDK_ToPluginFramework
✅ TestAccOctopusDeployLibraryVariableSetWithVariable
✅ TestAccUsernamePasswordBasic
✅ TestAccOctopusDeployDockerContainerRegistry
✅ TestEnvironmentResource_UpgradeFromSDK_ToPluginFramework
✅ TestAccOctopusDeployLibraryVariableSetComplex
✅ TestProjectInSpaceResource
✅ TestProjectTerraformInlineScriptExport
✅ TestUsernamePasswordVariableResource
✅ TestVariableSetResource
✅ TestEnvironmentResource
✅ TestGitCredentialBasic
✅ TestAccOctopusDeployLibraryVariableSetBasic
✅ TestProjectWithScriptActions
✅ TestArtifactoryGenericFeedResource_UpgradeFromSDK_ToPluginFramework
✅ TestAccLifecycleComplex
✅ TestRunbookResource
✅ TestAccTenantBasic
✅ TestTentacleCertificateResource
✅ TestMavenResource_UpgradeFromSDK_ToPluginFramework
✅ TestDockerFeedResource
✅ TestHelmFeedResource
✅ TestProjectResource
✅ TestProjectTerraformPackageScriptExport
✅ TestAccUsernamePasswordAccountImport
✅ TestSpaceResource_UpgradeFromSDK_ToPluginFramework
⚪ TestRunbookResource_UpgradeFromSDK_ToPluginFramework
⚪ TestAccOctopusDeployVariableBasic
✅ TestAccDataSourceSpaces
✅ TestAccDataSourceTagSets
✅ TestAccPreCheck
✅ TestExpandLifecycleWithNil
✅ TestExpandLifecycle
✅ TestExpandPhasesWithEmptyInput
✅ TestExpandPhasesWithNullInput
✅ TestExpandPhasesWithUnknownInput
✅ TestExpandAndFlattenPhasesWithSensibleDefaults
✅ TestExpandAndFlattenMultiplePhasesWithSensibleDefaults
✅ TestAccOctopusDeployNuGetFeedBasic
✅ TestExpandTagSet
✅ TestTenantResource_UpgradeFromSDK_ToPluginFramework
✅ TestUsernamePasswordAccountResource
✅ TestGitHubRepositoryFeed
✅ TestLifecycleResource
✅ TestNugetFeedResource
✅ TestAccProjectBasic
✅ TestAccTag
✅ TestAccTenantProjectVariableBasic
✅ TestAccDataSourceLifecycles
✅ TestAccOctopusDeployEnvironmentMinimum
✅ TestAccOctopusDeployMavenFeed
✅ TestProjectWithDollarSignsExport
✅ TestAccDataSourceEnvironments
✅ TestAccDataSourceSpaces
✅ TestTenantVariablesResource
✅ TestAccDataSourceTenants
✅ TestGitHubFeed_UpgradeFromSDK_ToPluginFramework
✅ TestAccOctopusDeployHelmFeed
✅ TestAccProjectWithUpdate
✅ TestHelmFeedResource_UpgradeFromSDK_ToPluginFramework
✅ TestAccLifecycleBasic
✅ TestMavenFeedResource

✅ github.com/OctopusDeploy/terraform-provider-octopusdeploy/octopusdeploy_framework/schemas

✅ TestDatasourceSchemaDefinitionIsUsingCorrectTypes
✅ TestResourceSchemaDefinitionIsUsingCorrectTypes
✅ TestExpandPromptedDisplaySettingsWithNilInput
✅ TestExpandPromptedDisplaySettingsWithEmptyInput
✅ TestExpandPromptedDisplaySettingsWithCheckbox
✅ TestExpandPromptedDisplaySettingsWithSelect
✅ TestExpandPromptedVariableSettingsWithNilInput
✅ TestExpandPromptedVariableSettingsWithEmptyInput
✅ TestExpandSelectOptionsWithNilInput
✅ TestExpandSelectOptionsWithEmptyInput
✅ TestFlattenPromptedVariableDisplaySettingsWithNilInput
✅ TestFlattenPromptedVariableSettingsWithNilInput
✅ TestFlattenSelectOptionsWithNilInput
✅ TestExpandVariableScope
✅ TestFlattenVariableScope