Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect machine policy id in kubernetes agent deployment target #807

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: respect machine policy id in kubernetes agent deployment target #807

merged 2 commits into from
Oct 30, 2024

Conversation

susanpann
Copy link
Collaborator

@susanpann susanpann commented Oct 29, 2024 •
edited
Loading

machine_policy_id doesn't get set when creating or updating octopusdeploy_kubernetes_agent_deployment_target

Fixes #806

mik-ky
mik-ky approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@mik-ky mik-ky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Looks like all the other properties are expanded correctly and this is the only missing one.

@tothegills
Copy link
Collaborator

Does schema_kubernetes_agent_worker need the same treatment?

@susanpann
Copy link
Collaborator Author

Good pickup, have added it for schema_kubernetes_agent_worker as well

@susanpann susanpann merged commit 794878b into main Oct 30, 2024
22 checks passed
@susanpann susanpann deleted the susan/kubernetesAgentMachinePolicy branch October 30, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-ky mik-ky mik-ky approved these changes

@tothegills tothegills tothegills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Machine policy not respected for kubernetes agent deployment target resource
3 participants
@susanpann @tothegills @mik-ky