Add Git Triggers #811
Open
Add Git Triggers #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lourens-octopus
force-pushed
the
lourens/add-git-triggers
branch
from
5f1bbe6 to
eae99da
Compare
lourens-octopus
force-pushed
the
lourens/add-git-triggers
branch
from
eae99da to
7990610
Compare
| channel_id = "Channels-1" | ||
| sources { | ||
| deployment_action_slug = "deploy-action-slug" | ||
| git_dependency_name = "" |
There was a problem hiding this comment.
🤔 the formatting ended up a bit wonky here
There was a problem hiding this comment.
Ah right I think its coming from the example file
| sources { | ||
| deployment_action_slug = "deploy-action-slug" | ||
| git_dependency_name = "" | ||
| include_file_paths = ["include/me", "include/me/too"] |
There was a problem hiding this comment.
These support glob patterns, including single directory * and multi-directory **, might be good to include some examples of those in here.
| ### Optional | ||
|
|
||
| - `is_disabled` (Boolean) Disables the trigger from being run when set. | ||
| - `sources` (Block List) List of Git trigger sources. Contains details of the deployment action slug, the git dependency and what file paths to monitor. (see [below for nested schema](#nestedblock--sources)) |
There was a problem hiding this comment.
Are Git trigger sources optional? What happens if you supply an empty list, do we allow that? I suppose it just doesn't do anything which might be ok.
There was a problem hiding this comment.
Do we have any way to add tests around these resource functions to prove that things get serialized/deserialized correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-85541]
Add Git Triggers