Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin_login attribute to azure authentication block #819

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

denys-octopus
Copy link
Contributor

@denys-octopus denys-octopus commented Nov 19, 2024

Affected resource: octopusdeploy_kubernetes_cluster_deployment_target
admin_login attribute is specific to azure_service_principal_authentication, but available only on endpoint's authentication block, which is flattened representation of different authentication types, and not getting mapped to the azure authentication.

This PR adds new attribute admin_login to azure_service_principal_authentication.

Fixes: #341

Copy link
Contributor

@domenicsim1 domenicsim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@denys-octopus denys-octopus merged commit 696ec1f into main Nov 19, 2024
22 checks passed
@denys-octopus denys-octopus deleted the dk/admin-login-attribute branch November 19, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for aks-deployment target with --admin flag
2 participants