Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project persistence settings #844

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Fix project persistence settings #844

merged 2 commits into from
Dec 24, 2024

Conversation

mik-ky
Copy link
Collaborator

@mik-ky mik-ky commented Dec 23, 2024

Fixes #787

Also fixes an issue where a default value for a basepath is not set when not provided. This is a regression from cb9c421 as the default value of ".octopus" was provided before.

(I can't seem to create an issue, so I wasn't able to create an issue for the second issue).

Copy link
Collaborator

@bec-callow-oct bec-callow-oct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mik-ky mik-ky merged commit 857bb8f into main Dec 24, 2024
24 checks passed
@mik-ky mik-ky deleted the ck/fix-persistence-settings branch December 24, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create octopusdeploy_project with git_username_password_persistence_settings
2 participants