Channel::Home tab missing thumbnails #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 3015 ## Symptom In Channel::Home tab, a Playlist row that contains playlists without a thumbnail should be showing the first claim's thumbnail instead. ## Root - If ClaimListDiscover is used, it's supposed to handle the search part (which also covers the thumbnail fetch). Clients just pass in the params. - The Home tab is handling the search instead, so some logic was missed. ## Fix Just mimic the missed logic for now. There is an open ticket to make ClaimListDiscover to be more customizable/composible so that logic remains centralized, but that probably won't be happening soon. Ideas from https://www.youtube.com/watch?v=vot0nJJ2Qdo seem useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: Closes #3015
Test:
infSymptom
In Channel::Home tab, a Playlist row that contains playlists without a thumbnail should be showing the first claim's thumbnail instead.
Root
Fix
Just mimic the missed logic for now.
There is an open ticket to make ClaimListDiscover to be more customizable/composible so that logic remains centralized, but that probably won't be happening soon. Ideas from https://www.youtube.com/watch?v=vot0nJJ2Qdo seem useful.