Collect all the Meter fields for prometheus #299
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RateX() fields were not being collected.
Testing done
Prior to the change, the only metric is
compact_time
for the prometheus endpoint:After the change, there is a
compact_time
metric shown with labels for each of the rates and there is also acompact_time_count
metric which just has the count.This would add an extra 740 metrics to the prometheus endpoint for Nitro which uses go-ethereum, on top of the existing 687.