Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multi Hub] Tab Calander- Nodejs Sample #837

Closed
wants to merge 22 commits into from
Closed

[Multi Hub] Tab Calander- Nodejs Sample #837

wants to merge 22 commits into from

Conversation

Harikrishnan-MSFT
Copy link
Contributor

No description provided.

@Harikrishnan-MSFT Harikrishnan-MSFT changed the title Initial code checkIn tab calendar Tab Calendar Meta-OS Nodejs Sample Jun 19, 2023
@Harikrishnan-MSFT Harikrishnan-MSFT requested review from Prithvi-MSFT and removed request for Mohammed-MSFT June 20, 2023 07:19
@Harikrishnan-MSFT
Copy link
Contributor Author

Build Pipeline -
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/5320066977
image

@ChetanSharma-msft ChetanSharma-msft changed the title Tab Calendar Meta-OS Nodejs Sample [Meta OS] Tab Calendar Nodejs Sample Jun 20, 2023
@ChetanSharma-msft ChetanSharma-msft changed the title [Meta OS] Tab Calendar Nodejs Sample [MetaOS] Tab Calendar Nodejs Sample Jun 20, 2023
@ChetanSharma-msft ChetanSharma-msft changed the title [MetaOS] Tab Calendar Nodejs Sample [Multi Hub] Tab Calendar Nodejs Sample Jun 20, 2023
ChetanSharma-msft
ChetanSharma-msft requested changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my review comments.

README.md Outdated Show resolved Hide resolved
samples/tab-calendar/ts/Manifest/manifest.json Outdated Show resolved Hide resolved
samples/tab-calendar/ts/Manifest/manifest.json Outdated Show resolved Hide resolved
samples/tab-calendar/ts/Manifest/manifest.json Outdated Show resolved Hide resolved
samples/tab-calendar/ts/Manifest/manifest.json Outdated Show resolved Hide resolved
samples/tab-calendar/ts/src/components/Tab.tsx Outdated Show resolved Hide resolved
samples/tab-calendar/ts/src/components/Tab.tsx Outdated Show resolved Hide resolved
samples/tab-calendar/ts/src/components/Tab.tsx Outdated Show resolved Hide resolved
samples/tab-calendar/ts/src/components/TabCalendarMain.tsx Outdated Show resolved Hide resolved
.github/workflows/build-complete-samples.yml
@@ -898,6 +898,14 @@ jobs:
- project_path: 'samples/meetings-app-icon-badging/nodejs'
name: 'meetings-app-icon-badging'
version: '18.x'

- project_path: 'samples/tab-calendar/ts/api-server'
name: 'tab-calendar-api-server'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to create deploy pipeline.

@OfficeDev OfficeDev deleted a comment from ChetanSharma-msft Jun 22, 2023
@OfficeDev OfficeDev deleted a comment from ChetanSharma-msft Jun 22, 2023
ChetanSharma-msft
ChetanSharma-msft approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few minor comments.

README.md Outdated Show resolved Hide resolved
samples/tab-calendar/ts/Manifest/manifest.json Outdated Show resolved Hide resolved
samples/tab-calendar/ts/public/index.html Outdated Show resolved Hide resolved
ChetanSharma-msft
ChetanSharma-msft requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one review comment.

samples/tab-calendar/ts/README.md Show resolved Hide resolved
ChetanSharma-msft
ChetanSharma-msft approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine, approving it.

@Harikrishnan-MSFT
Copy link
Contributor Author

Build Pipeline -
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/5419679210

image

@Harikrishnan-MSFT Harikrishnan-MSFT changed the title [Multi Hub] Tab Calendar Nodejs Sample [Multi Hub] Tab Calander, Mail , Profile - Nodejs Sample Jul 3, 2023
@Harikrishnan-MSFT Harikrishnan-MSFT changed the title [Multi Hub] Tab Calander, Mail , Profile - Nodejs Sample [Multi Hub] Tab Calander- Nodejs Sample Jul 3, 2023
@Harikrishnan-MSFT Harikrishnan-MSFT added the duplicate This issue or pull request already exists label Jul 4, 2023
@ChetanSharma-msft
Copy link
Collaborator

Duplicate of: #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChetanSharma-msft ChetanSharma-msft ChetanSharma-msft approved these changes

@Prithvi-MSFT Prithvi-MSFT Awaiting requested review from Prithvi-MSFT

@Pawan-MSFT Pawan-MSFT Awaiting requested review from Pawan-MSFT

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harikrishnan-MSFT @ChetanSharma-msft