Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi Hub] Tab Mail Sample #838

Closed
wants to merge 12 commits into from
Closed

Conversation

Mohammed-MSFT
Copy link
Contributor

No description provided.

@ChetanSharma-msft ChetanSharma-msft changed the title Tab Mail Meta-OS Sample [MetaOS] Tab Mail Sample Jun 20, 2023
@ChetanSharma-msft ChetanSharma-msft changed the title [MetaOS] Tab Mail Sample [Multi Hub] Tab Mail Sample Jun 20, 2023
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my review comments on your PR.

README.md Outdated Show resolved Hide resolved
@@ -54,6 +54,7 @@ The [Teams Toolkit](https://marketplace.visualstudio.com/items?itemName=TeamsDev
|21| Personal Tab with Nav-Bar menu | Add multiple actions to the upper right in Nav-Bar and build an overflow menu for extra actions in an app. ||[View][tab-navbar-menu#ts]|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and deploy pipelines are missing for this new sample.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohammed-MSFT - Deploy pipeline is still missing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

samples/tab-mail/ts/README.md Outdated Show resolved Hide resolved
samples/tab-mail/ts/Manifest/manifest.json Show resolved Hide resolved
samples/tab-mail/ts/Manifest/manifest.json Outdated Show resolved Hide resolved
samples/tab-mail/ts/src/components/Tab.tsx Outdated Show resolved Hide resolved
samples/tab-mail/ts/src/components/Tab.tsx Outdated Show resolved Hide resolved
samples/tab-mail/ts/src/components/Tab.tsx Outdated Show resolved Hide resolved
samples/tab-mail/ts/src/components/home.css Show resolved Hide resolved
samples/tab-mail/ts/tsconfig.json Show resolved Hide resolved
@ChetanSharma-msft
Copy link
Collaborator

ChetanSharma-msft commented Jun 23, 2023

@Mohammed-MSFT - Please run build pipeline.
Executed Build pipeline : https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/5357600362

image

Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my review comments.

@@ -54,6 +54,7 @@ The [Teams Toolkit](https://marketplace.visualstudio.com/items?itemName=TeamsDev
|21| Personal Tab with Nav-Bar menu | Add multiple actions to the upper right in Nav-Bar and build an overflow menu for extra actions in an app. ||[View][tab-navbar-menu#ts]|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohammed-MSFT - Deploy pipeline is still missing.

@@ -54,6 +54,7 @@ The [Teams Toolkit](https://marketplace.visualstudio.com/items?itemName=TeamsDev
|21| Personal Tab with Nav-Bar menu | Add multiple actions to the upper right in Nav-Bar and build an overflow menu for extra actions in an app. ||[View][tab-navbar-menu#ts]|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

samples/tab-mail/ts/Manifest/manifest.json Show resolved Hide resolved
samples/tab-mail/ts/README.md Outdated Show resolved Hide resolved
samples/tab-mail/ts/assets/sample.json Outdated Show resolved Hide resolved
samples/tab-mail/ts/assets/sample.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one more comment.

samples/tab-mail/ts/src/index.tsx Show resolved Hide resolved
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my review comment.

samples/tab-mail/ts/README.md Show resolved Hide resolved
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine, approving it.

@Harikrishnan-MSFT Harikrishnan-MSFT added the duplicate This issue or pull request already exists label Jul 4, 2023
@ChetanSharma-msft
Copy link
Collaborator

Duplicate of: #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants