-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional FeatureSet parameter to eligibility interface #2623
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e56cc4d
Adding optional feature sets to eligibility data
lakhveerk 9afa14f
changefile
lakhveerk 8f756b1
updating interface
lakhveerk 80b2434
adding UTs
lakhveerk a43f2e2
Adding UT
lakhveerk 1a98d9c
Merge branch 'main' of https://github.com/OfficeDev/microsoft-teams-l…
lakhveerk b867727
Merge branch 'main' of https://github.com/OfficeDev/microsoft-teams-l…
lakhveerk ad12899
Merge branch 'main' into lakhveer/eligibility
lakhveerk 99f1577
Merge branch 'main' of https://github.com/OfficeDev/microsoft-teams-l…
lakhveerk af49dad
make the feature set property readyOnly
lakhveerk 799ad13
Merge branch 'lakhveer/eligibility' of https://github.com/OfficeDev/m…
lakhveerk e4466bb
Merge branch 'main' into lakhveer/eligibility
lakhveerk 51fa692
Merge branch 'main' into lakhveer/eligibility
AE-MS ab3d79b
Merge branch 'main' into lakhveer/eligibility
lakhveerk 1d46802
Merge branch 'main' of https://github.com/OfficeDev/microsoft-teams-l…
lakhveerk 2fc87a4
Merge branch 'lakhveer/eligibility' of https://github.com/OfficeDev/m…
lakhveerk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@microsoft-teams-js-fc4a8f34-92ca-48dc-9c74-c84d8eed6a89.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "minor", | ||
"comment": "Added optional `FeatureSet` field to `AppEligibilityInformation` interface", | ||
"packageName": "@microsoft/teams-js", | ||
"email": "email not defined", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the semantic difference between having this property be
undefined
vs defined but with two empty array properties?I'm guessing the answer is something like "this has to have the
?
because older version of the host won't know to send this property so it will show up as undefined then." If that's true, then consider adding documentation for the property that says:"If this property is undefined, it indicates that the host is an older version that doesn't support this property." #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is it's the latter, so I think adding a comment is the way to go here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep it is for back compatibility. Added the comment!