Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nested App Auth API sections to the teams test app #2641

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

baljesingh
Copy link
Contributor

Description

Add three new API sections to the Teams test app for UI testing:

  1. SendMessageToNestedAppAuthBridge - Send a NAA message to the nested app auth bridge.
  2. SendMessageToTopWindow - Send NAA message to the top window.
  3. AddChildIframeSection - Add a child nested iframe, which can also call APIs 1 and 2.

Main changes in the PR:

  1. Added SendMessageToNestedAppAuthBridge, SendMessageToTopWindow, AddChildIframeSection in NestedAppAuthAPIs.tsx

Validation

Validation performed:

  1. Yes, locally using SDK UI testing framework.

Unit Tests added:

N/A

End-to-end tests added:

N/A

Additional Requirements

Change file added: N/A

Ensure the change file meets the formatting requirements.

<Yes/No>

Related PRs:

Remove this section if n/a

Next/remaining steps:

List the next or remaining steps in implementing the overall feature in subsequent PRs (or is the feature 100% complete after this?).

Remove this section if n/a

  • Item 1
  • Item 2

Screenshots:

Remove this section if n/a

Before After
< image1 > < image2 >

@baljesingh baljesingh requested a review from a team as a code owner November 25, 2024 19:04
@baljesingh baljesingh changed the title Baljesingh/e2 e test for naa Add Nested App Auth API sections to the teams test app Nov 25, 2024
maglims
maglims previously approved these changes Nov 25, 2024
disabled={iframeAdded}
/>
<div
id="NestedChildiframeContainer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: this should be nestedChildIframeContainer to match casing elsewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Thank you.

Copy link
Contributor

@TrevorJoelHarris TrevorJoelHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when it's ready for review again

@baljesingh baljesingh closed this Nov 27, 2024
@baljesingh baljesingh reopened this Nov 27, 2024
@baljesingh baljesingh force-pushed the baljesingh/E2ETestForNAA branch from 089456b to d04501b Compare November 27, 2024 22:13
@baljesingh baljesingh merged commit 13d62af into main Nov 27, 2024
27 checks passed
@baljesingh baljesingh deleted the baljesingh/E2ETestForNAA branch November 27, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants