add ics filter params #2647
Open
add ics filter params #2647
+462
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pending until hub-sdk pr checked in |
change/@microsoft-teams-js-dda2304f-2384-4778-83a4-caa10d929abf.json
Outdated
Show resolved
Hide resolved
…f.json Co-authored-by: Trevor Harris <trharris@microsoft.com>
TrevorJoelHarris
requested changes
Dec 5, 2024
Co-authored-by: Trevor Harris <trharris@microsoft.com>
…ibrary-js into users/hangyin/1204_ics
YinHang2515
changed the title
YinHang2515
changed the title
TrevorJoelHarris
requested changes
Jan 7, 2025
…ibrary-js into users/hangyin/1204_ics
…/microsoft-teams-library-js into users/hangyin/1204_ics
TrevorJoelHarris
previously approved these changes
Jan 9, 2025
…ibrary-js into users/hangyin/1204_ics
| appCapability?: string; | ||
|
|
||
| /** | ||
| * The application meta capabilities (e.g., ["copilotPlugins", "copilotExtensions"]). |
There was a problem hiding this comment.
If it's correct that this can be undefined, this comment should outline what it means for there to be no array specified.
| * @internal | ||
| * Limited to Microsoft-internal use | ||
| */ | ||
| export const errorMissingCollectionId = | ||
| 'No Collection Id present, but CollectionId needed to open a store specific to a collection'; | ||
| export async function openInContextStore(params: OpenInContextStoreParams): Promise<void> { |
There was a problem hiding this comment.
Since this is a private function I don't feel strongly about it, but right now every parameter in OpenInContextStoreParams is optional. To me, that means it would make sense if params was optional here as well. That way a caller who wanted all of the default values could write code like this:
await openInContextStore();instead of this:
await openInContextStore({});Something to consider.
TrevorJoelHarris
requested changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
re-add otherAppState and Store e2e tests & add store size interface & add ics filter params
Main changes in the PR:
Validation
Validation performed:
Unit Tests added:
No. No need for this change
End-to-end tests added:
Yes
Additional Requirements
Change file added:
Yes