Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Spool Selection Comment for API Submitted gcode Files #18

Open
tduehr opened this issue Jul 25, 2020 · 13 comments
Open

Magic Spool Selection Comment for API Submitted gcode Files #18

tduehr opened this issue Jul 25, 2020 · 13 comments

Comments

@tduehr
Copy link

tduehr commented Jul 25, 2020

I submit most jobs through the API with Cura or Prusa Slic3r. Being able to select the spool in GCODE would help me track filament usage correctly without having to open a browser every time.

@OllisGit
Copy link
Owner

Hi @tduehr ,

this is a good idea and this is already on my long-term list, see Backlog: https://github.com/OllisGit/OctoPrint-SpoolManager/projects/1

@stale
Copy link

stale bot commented Sep 1, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Sep 1, 2020
@OllisGit
Copy link
Owner

OllisGit commented Sep 3, 2020

Hi @tduehr ,
do you know a "standard" gcode-comand to identify a spool selection?
If I use a comment instead, like ;spool_selection=My Best Spool then I need to parse the file at the beginning. But this is not possible for SD-Card prints, because OP has no access to this.
Or is there a "standard" comment in your slices for selecting a spool?

@stale stale bot removed the status: markedForAutoClose Issue will be closed automatically label Sep 3, 2020
@OllisGit OllisGit added the status: waitingForFeedback Wating for Customers feedback label Sep 3, 2020
@wchill
Copy link

wchill commented Sep 5, 2020

@OllisGit maybe take advantage of the M118 gcode for SD card prints? So adding something like M118 A1 spool:My Best Spool to a gcode file before printing could signal the plugin to select that spool.

@tduehr
Copy link
Author

tduehr commented Sep 7, 2020

I don't use the SD card myself so I'm tempted to say it's not really something you can do. M118 sounds like a good idea. It'd be nice if there was a way to do the spool selection that prusa slic3r uses.

How much of the print information from an SD print is available anyway? Should this be handled by some sort of manual process to add/modify a print?

@xunleii
Copy link

xunleii commented Sep 28, 2020

I think using the M118 command can be great and could be easily managed by the on_sentGCodeHook hook (cf. https://github.com/OllisGit/OctoPrint-SpoolManager/blob/master/octoprint_SpoolManager/__init__.py#L367). But, I can't see how we can ignore the Spool warning message without reading the GCode before.

Also, I suggest M118 A1 spool:<filament_id>:<spool_name> (or something like that) instead of ``M118 A1 spool:<spool_name>` to prepare for the multi-filament feature.

What do you think ?

@wchill
Copy link

wchill commented Sep 28, 2020

Better would be to replicate what OctoPrint-ActionCommandsPlugin is doing:

https://github.com/benlye/OctoPrint-ActionCommandsPlugin/blob/ed03e15e96f52140b4066d58ba069e3612cca30d/octoprint_actioncommands/__init__.py#L24

The hook there lets you inspect serial input coming from the printer, which works well when you use M118 and should work even for SD card prints. Though you're right, the spool warning might not be easy to fix without preprocessing.

@wchill
Copy link

wchill commented Sep 29, 2020

@OllisGit do you mind if I take this feature? I need something to work on for Hacktoberfest and I just recently got a MMU2S so it'll be useful for me anyway.

@stale
Copy link

stale bot commented Oct 29, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Oct 29, 2020
@stale stale bot closed this as completed Nov 8, 2020
@samwiseg0
Copy link

samwiseg0 commented Mar 6, 2021

I was going to put in this request. Is there any chance we can re-open this issue? I think it would be a great idea since you can set filament gcode in prusaslicer and possibility others?

@OllisGit OllisGit added FEATURE: FILAMENT SELECTION and removed status: markedForAutoClose Issue will be closed automatically status: waitingForFeedback Wating for Customers feedback labels Jun 5, 2021
@OllisGit OllisGit reopened this Jun 5, 2021
@github-actions
Copy link

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions github-actions bot added the status: markedForAutoClose Issue will be closed automatically label Jan 15, 2022
@OllisGit OllisGit added status: analysing and removed status: markedForAutoClose Issue will be closed automatically labels Jan 16, 2022
@OllisGit
Copy link
Owner

fyi: Not closed any more, because I want to implement this in one of the next releases.

@FabioForcina
Copy link

Are there any news about this addition?

mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
mdziekon referenced this issue in mdziekon/OctoPrint-SpoolManager Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants