Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left_join instead of full_join in ae_table_grade() #2

Open
4 tasks
DanChaltiel opened this issue Sep 12, 2024 · 0 comments
Open
4 tasks

Left_join instead of full_join in ae_table_grade() #2

DanChaltiel opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
v0.2

Comments

@DanChaltiel
Copy link
Member

As mentioned by @BaptisteArchambaud, a left_join makes more sense here:

https://github.com/Oncostat/grstat/blob/main/R/ae_table_grade.R#L69

  • make the change
  • add an example in the doc where the population is filtered (e.g. only treated patients)
  • if verbose, add a message describing the filtering ae_table: N patients excluded
  • add a test
@DanChaltiel DanChaltiel added the bug Something isn't working label Sep 12, 2024
@DanChaltiel DanChaltiel mentioned this issue Sep 12, 2024
Closed
4 tasks
@DanChaltiel DanChaltiel added this to the v0.2 milestone Sep 23, 2024
DanChaltiel added a commit that referenced this issue Sep 23, 2024
@DanChaltiel
Changed full_joins to left_joins
5a9c1b9 
improves #2
DanChaltiel added a commit that referenced this issue Sep 23, 2024
@DanChaltiel
fixed join in butterfly_plot()
8d93f45 
improves on #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@DanChaltiel