New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad sorting in `ae_table_soc()` #8

Open

2 tasks

DanChaltiel opened this issue Sep 18, 2024 · 0 comments

Assignees

Labels

bug

Milestone

Member

DanChaltiel commented Sep 18, 2024 •

edited

Loading

If some AEs happen only in the right-panel treatment arm, the soc is sorted after "No Declared AE".

Fix is to arrange by soc after the pivot_wider() here:

grstat/R/ae_table_soc.R

Lines 147 to 150 in d5ec966

    
           rtn = rtn %>% 
        
             rename(soc=soc_) %>% 
        
             pivot_wider_spec(spec) %>% 
        
             add_class("ae_table_soc")

Fix the bug
add a test

Workaround: arrange by "soc" outside the function works as well

The text was updated successfully, but these errors were encountered:

DanChaltiel added the bug label

DanChaltiel self-assigned this

DanChaltiel added this to the v0.2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment