Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add official 1.20.6 support #13

Merged
merged 7 commits into from
Jun 7, 2024
Merged

add official 1.20.6 support #13

merged 7 commits into from
Jun 7, 2024

Conversation

NonSwag
Copy link

@NonSwag NonSwag commented Jun 7, 2024

Description

This PR adds official support for 1.20.6

  • cloud command framework was updated to utilize the latest addition of paper brigadier
  • removed dead versions from "supported" list

Checklist

  • I included all information required in the sections above
  • I tested my changes and approved their functionality
  • I ensured my changes do not break other parts of the code

@NonSwag NonSwag requested a review from TheMeinerLP as a code owner June 7, 2024 14:24
TheMeinerLP
TheMeinerLP approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally. Only a generic fawe bug is present but thats fine

@TheMeinerLP TheMeinerLP merged commit 56a975b into OneLiteFeatherNET:master Jun 7, 2024
6 checks passed
@NonSwag
Copy link
Author

NonSwag commented Jun 7, 2024

what do you mean by generic fawe bug ?

@TheMeinerLP
Copy link
Collaborator

image
Ref: IntellectualSites/FastAsyncWorldEdit#2752
Ref2: IntellectualSites/FastAsyncWorldEdit#2742

@NonSwag
Copy link
Author

NonSwag commented Jun 7, 2024

oh thats unrelated then

@NonSwag NonSwag deleted the 1.20.6 branch June 7, 2024 16:33
@TheMeinerLP
Copy link
Collaborator

Not really, we use that API to create our config

@TheMeinerLP TheMeinerLP mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMeinerLP TheMeinerLP TheMeinerLP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NonSwag @TheMeinerLP