Skip to content

Commit

Permalink
Update from node 14 to node 18
Browse files Browse the repository at this point in the history
Updated to the latest available LTS.
Introduced .nvmrc file to share the node version between cd / ci files.
  • Loading branch information
jkasten2 committed Sep 29, 2023
1 parent beffd4f commit 241f6fb
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 14 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,12 @@ jobs:
test_build_deploy:
runs-on: ubuntu-22.04

strategy:
matrix:
node-version: [14.x]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version-file: '.nvmrc'
- name: "[Setup] Install dependencies"
run: yarn
- name: "[Build] Staging"
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,12 @@ jobs:
test:
runs-on: ubuntu-22.04

strategy:
matrix:
node-version: [14.x]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version-file: '.nvmrc'
- name: "[Setup] Install dependencies"
run: yarn
- name: "[Test] Run linters"
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.18.0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:14.21.1
FROM node:18.18.0
WORKDIR /sdk
COPY package.json .
RUN yarn
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@types/mocha": "^5.0.0",
"@types/nconf": "latest",
"@types/nock": "^9.1.2",
"@types/node": "^18.13.0",
"@types/node": "^18.18.0",
"@types/object-assign": "^4.0.30",
"@types/requirejs": "latest",
"@types/sinon": "^2.3.3",
Expand Down

0 comments on commit 241f6fb

Please sign in to comment.