Skip to content

Commit

Permalink
Node 18.18 introduced a new Disposable interface
Browse files Browse the repository at this point in the history
This new node interface was conflicting with our Disposable so renamed
ours to OSDisposable.
  • Loading branch information
jkasten2 committed Sep 29, 2023
1 parent aff2f61 commit a289bff
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/page/models/Disposable.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
interface Disposable {
interface OSDisposable {
dispose();
}
2 changes: 1 addition & 1 deletion src/page/modules/frames/ProxyFrameHost.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ interface Reply {
* This is loaded as subdomain.onesignal.com/webPushIFrame or
* subdomain.os.tc/webPushIFrame. *
*/
export default class ProxyFrameHost implements Disposable {
export default class ProxyFrameHost implements OSDisposable {
public url: URL;
private element: HTMLIFrameElement;
private messenger: Postmam;
Expand Down
2 changes: 1 addition & 1 deletion src/page/modules/frames/RemoteFrame.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface RemoteFrameOptions {
isModal?: boolean;
}

export default class RemoteFrame implements Disposable {
export default class RemoteFrame implements OSDisposable {
protected messenger: Postmam;
protected options: ProxyFrameInitOptions;

Expand Down
2 changes: 1 addition & 1 deletion src/page/modules/frames/SubscriptionModalHost.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Log from '../../../shared/libraries/Log';
* into the iFrame URL as subdomain.onesignal.com/webPushIFrame or
* subdomain.os.tc/webPushIFrame. *
*/
export default class SubscriptionModalHost implements Disposable {
export default class SubscriptionModalHost implements OSDisposable {
private messenger: Postmam;
private appId: string;
private modal: HTMLIFrameElement;
Expand Down
2 changes: 1 addition & 1 deletion src/page/modules/frames/SubscriptionPopupHost.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { RawPushSubscription } from '../../../shared/models/RawPushSubscription'
* This is loaded as subdomain.onesignal.com/webPushIFrame or
* subdomain.os.tc/webPushIFrame. *
*/
export default class SubscriptionPopupHost implements Disposable {
export default class SubscriptionPopupHost implements OSDisposable {
public url: URL;
private popupWindow: Window | undefined | null;
private messenger: Postmam | undefined;
Expand Down

0 comments on commit a289bff

Please sign in to comment.