Skip to content

Commit

Permalink
use root docker-compose.yml for vscode
Browse files Browse the repository at this point in the history
Motivation is recent versions of docker no longer consider
.devcontainer/docker-compose.yml valid, so vscode can't start the
container.
Solution here is just removing the specific vscode docker-compose.yml
so only the root one is used. There is nothing specific needed in
the vscode specific one anyway.
  • Loading branch information
jkasten2 committed Oct 17, 2023
1 parent 431c317 commit b83a9d1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 34 deletions.
5 changes: 1 addition & 4 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,9 @@
// Update the 'dockerComposeFile' list if you have more compose files or use different names.
// The .devcontainer/docker-compose.yml file contains any overrides you need/want to make.
"dockerComposeFile": [
"../docker-compose.yml",
"docker-compose.yml"
"../docker-compose.yml"
],

// The 'service' property is the name of the service for the container that VS Code should
// use. Update this value and .devcontainer/docker-compose.yml to the real service name.
"service": "onesignal-web-sdk-dev",

// The optional 'workspaceFolder' property is the path VS Code should open by default when
Expand Down
30 changes: 0 additions & 30 deletions .devcontainer/docker-compose.yml

This file was deleted.

0 comments on commit b83a9d1

Please sign in to comment.