Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] hide bell if user is subscribed, dashboard setting #1130

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Nov 14, 2023

Description

1 Line Summary

Fix "Hide bell if user is subscribed" that can be set in dashboard when configuring the bell.

Details

Validation

Tests

Tested on Chrome 119 on Windows 11.

  • Enabled the "Hide bell if user is subscribed" on the OneSignal.com dashboard and ensure the bell toggled based on both the native browser permission as well as the opt out setting.

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Dashboard option for reference:
image

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Option that can be set in dashboard when configuring the bell. Updated
to the new v16 function. Also corrected type that was incorrect for
displayPredicate
@jkasten2 jkasten2 requested review from rgomezp and emawby November 14, 2023 02:49
Base automatically changed from fix/add_email_and_sms_user_issues to main November 14, 2023 20:59
@jkasten2 jkasten2 merged commit 36d42a9 into main Nov 14, 2023
2 checks passed
@jkasten2 jkasten2 deleted the fix/hide_bell_if_user_is_subscribed branch November 14, 2023 20:59
@jkasten2 jkasten2 mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants