[Fix] Improve error for sites using os.tc subdomain #1139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Replaces confusing "TypeError: Cannot read properties of undefined (reading 'message')" with a specific error that HTTP and the "My site is not fully HTTPS" option is no longer supported.
Details
Before this change the initialization process would get too far and would result a confusing undefined error.
Dead code will be cleaned up follow up PR.
Validation
Tests
Tested with Chrome 119 on Windows 11
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of array
syntax. PreferforEach
or usemap
context
if possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.context
Screenshots
Before
After
Info
Checklist
Related Tickets
This change is