Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add getTags to public API #1140

Merged
merged 3 commits into from
Nov 21, 2023
Merged

[Feat] Add getTags to public API #1140

merged 3 commits into from
Nov 21, 2023

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Nov 17, 2023

Description

1 Line Summary

Adds the getTags method to the public API

Details

Calling the public API getTags method returns an empty dictionary {} when the user property model tags field is undefined

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

@shepherd-l shepherd-l force-pushed the feat/getTags branch 2 times, most recently from fcd87ab to 0c4997c Compare November 18, 2023 01:17
@@ -70,4 +70,8 @@ export default class UserNamespace {
public removeTags(keys: string[]): void {
this._currentUser?.removeTags(keys);
}

public getTags(): { [key: string]: string } {
return this._currentUser?.getTags() ? this._currentUser.getTags() : {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can shorten this by using || instead of the ternary operator here.

@shepherd-l shepherd-l merged commit 98c2807 into main Nov 21, 2023
4 checks passed
@shepherd-l shepherd-l deleted the feat/getTags branch November 21, 2023 17:28
@jkasten2 jkasten2 mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants